Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract <google-oauth> component #37

Open
jpoehnelt opened this issue Feb 10, 2025 · 0 comments
Open

Extract <google-oauth> component #37

jpoehnelt opened this issue Feb 10, 2025 · 0 comments
Assignees
@jpoehnelt
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Milestone
v1

Comments

@jpoehnelt
Copy link
Member

I have thought about extracting the OAuth into another component instead, <google-oauth>, or similar. I might reconsider this again prior to v1. This would make it a little more explicit and keep the declarative interface that could be pieced together in any framework. Again, some applications would already be using something like google login or onetap and already have a token.

<google-oauth client-id="" app-id="" scope="">
  <drive-picker>
      <drive-picker-docs-view/>
  </drive-picker>
</google-oauth>
@jpoehnelt jpoehnelt mentioned this issue Feb 10, 2025
Closed
@jpoehnelt jpoehnelt added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Feb 10, 2025
@jpoehnelt jpoehnelt added this to the v1 milestone Feb 10, 2025
This was referenced Feb 10, 2025
Closed
Merged
@jpoehnelt jpoehnelt added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpoehnelt jpoehnelt

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Milestone
v1
Development

No branches or pull requests
1 participant
@jpoehnelt