Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use requestBody instead of resource #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use requestBody instead of resource #345

wants to merge 1 commit into from

Conversation

faheel
Copy link

@faheel faheel commented Jan 28, 2023

The resource key was changed to requestBody in Google APIs v40 (googleapis/google-api-nodejs-client#1149)

Though using resource still works, the TypeScript definitions in https://github.com/googleapis/google-api-nodejs-client only include requestBody, so using resource causes the TypeScript compiler to show an error.

Closes #77

@faheel faheel mentioned this pull request Jun 21, 2023
Open
@faheel
Copy link
Author

faheel commented Jun 21, 2023

@jpoehnelt Can you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jpoehnelt jpoehnelt

Labels
javascript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade samples to v40 and use new requestBody key
2 participants
@faheel @jpoehnelt