Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

termbox panic on unknown TERM #1072

Closed
yrps opened this issue Feb 21, 2019 · 1 comment
Closed

termbox panic on unknown TERM #1072

yrps opened this issue Feb 21, 2019 · 1 comment
Assignees
Labels
bug Defects

Comments

@yrps
Copy link

yrps commented Feb 21, 2019

gopass dies ungracefully if it can't find the terminfo definition it's looking for.

Maybe it's termbox's fault, but a brief message to stderr would be a nice alternative.

Installed from the gopass-1.8.4-2 package for Arch linux, amd64.

$ TERM=asdf gopass w
zsh: can't find terminal definition for asdf   
Entry 'w' not found. Starting search...       
panic: termbox: error while reading terminfo data: termbox: unsupported terminal
                                                   
goroutine 1 [running]:                                              
github.com/gopasspw/gopass/pkg/cui.GetSelection(0x55c8e8ac2620, 0xc0002d4570, 0x55c8e87797ed, 0x26, 0x55c8e8787d45, 0x68, 0xc00039ca80, 0x54, 0xa8, 0x0, ...)              
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/cui/cui.go:184 +0x4b0                                                                                         
github.com/gopasspw/gopass/pkg/action.(*Action).findSelection(0xc000244b60, 0x55c8e8ac2620, 0xc0002d4570, 0xc000108b00, 0xc00039ca80, 0x54, 0xa8, 0x7ffddc22a814, 0x1, 0xc0
00253998, ...)                 
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/action/find.go:77 +0xcb                                                                                       
github.com/gopasspw/gopass/pkg/action.(*Action).find(0xc000244b60, 0x55c8e8ac2620, 0xc0002d4570, 0xc000108b00, 0x7ffddc22a814, 0x1, 0xc000253998, 0x0, 0x0)
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/action/find.go:71 +0x36d
github.com/gopasspw/gopass/pkg/action.(*Action).Find(0xc000244b60, 0x55c8e8ac2620, 0xc0002d4570, 0xc000108b00, 0xc0002de1c0, 0x1)
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/action/find.go:27 +0xe3
github.com/gopasspw/gopass/pkg/action.(*Action).showHandleError(0xc000244b60, 0x55c8e8ac2620, 0xc0002d4570, 0xc000108b00, 0x7ffddc22a814, 0x1, 0x1, 0x55c8e8abbea0, 0xc0000
a00e0, 0x55c8e8abbea0, ...)                       
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/action/show.go:139 +0x2f7
github.com/gopasspw/gopass/pkg/action.(*Action).show(0xc000244b60, 0x55c8e8ac2620, 0xc0002d43c0, 0xc000108b00, 0x7ffddc22a814, 0x1, 0x0, 0x0, 0xc00024a201, 0x5, ...)
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/action/show.go:72 +0x253
github.com/gopasspw/gopass/pkg/action.(*Action).Show(0xc000244b60, 0x55c8e8ac2620, 0xc0002d43c0, 0xc000108b00, 0xc000157740, 0x0)                                          
        /build/gopass/src/src/github.com/gopasspw/gopass/pkg/action/show.go:42 +0x37e                                                                                      
main.setupApp.func2(0xc000108b00, 0x0, 0x0)                                                                                                                                
        gopass-1.8.4/app.go:62 +0x1fb
github.com/urfave/cli.HandleAction(0x55c8e89dbe80, 0xc0000a1740, 0xc000108b00, 0x0, 0x0)
        /build/gopass/src/src/github.com/urfave/cli/app.go:501 +0xca
github.com/urfave/cli.(*App).Run(0xc0001241c0, 0xc0000a0000, 0x2, 0x2, 0x0, 0x0)
        /build/gopass/src/src/github.com/urfave/cli/app.go:268 +0x5b9
main.main()
        gopass-1.8.4/main.go:67 +0x304
$
@dominikschulz dominikschulz added the bug Defects label Feb 24, 2019
@dominikschulz dominikschulz self-assigned this Feb 24, 2019
@dominikschulz dominikschulz added this to the 1.8.5 - Bugfix release milestone Feb 24, 2019
@stale
Copy link

stale bot commented May 25, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

No branches or pull requests

2 participants