Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed command execution message #129

Closed
alexluix opened this issue Aug 27, 2019 · 4 comments · Fixed by #139
Closed

Fix failed command execution message #129

alexluix opened this issue Aug 27, 2019 · 4 comments · Fixed by #139
Assignees
Labels
bug Bug in existing flow documentation Create/Update documents good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/
Milestone

Comments

@alexluix
Copy link
Collaborator

alexluix commented Aug 27, 2019

Description

Failed to execute 'mvn clean verify'

it is not failed to execute
it is that this command was executed and failed

Acceptance Criteria

  • the message says exactly what happened – e.g. : Command * failed – execution of the following commands skipped: *
  • Specify exit-code of command in message
@gopinath-langote gopinath-langote added documentation Create/Update documents bug Bug in existing flow help wanted Extra attention is needed good first issue Good for first time contributors labels Aug 27, 2019
@gopinath-langote gopinath-langote added this to the v2.0.0 milestone Aug 27, 2019
@gopinath-langote gopinath-langote pinned this issue Aug 30, 2019
@linonymous
Copy link

Hi There, was wondering if there is any specific reason that we have used '"github.com/codeskyblue/go-sh"' package instead of the already provided "os/exec" package.

@gopinath-langote gopinath-langote added the Hacktoberfest Support to https://hacktoberfest.digitalocean.com/ label Sep 12, 2019
@gopinath-langote
Copy link
Owner

Hello @linonymous,

One reason behind using special library was to get session support - With "os/exec" – we have to control session (having env variables etc). With go-sh - it is easy to manage session, chain commands etc.

@akhilbojedla
Copy link
Contributor

akhilbojedla commented Sep 12, 2019

@gopinath-langote May be mentioning the exit code of command in message is more appropriate. wdyt?

@gopinath-langote
Copy link
Owner

gopinath-langote commented Sep 13, 2019

Hello @akhilbojedla,

Yes, you are right. Adding exit code is a good idea.

Updated the AC accordingly

@gopinath-langote gopinath-langote added In Progress Someone working on the issue and removed help wanted Extra attention is needed labels Sep 15, 2019
@gopinath-langote gopinath-langote removed the In Progress Someone working on the issue label Sep 17, 2019
@gopinath-langote gopinath-langote unpinned this issue Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in existing flow documentation Create/Update documents good first issue Good for first time contributors Hacktoberfest Support to https://hacktoberfest.digitalocean.com/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants