Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdn.jsdelivr.net blocked by GFW #727

Closed
nighca opened this issue Aug 9, 2024 · 0 comments · Fixed by #729
Closed

cdn.jsdelivr.net blocked by GFW #727

nighca opened this issue Aug 9, 2024 · 0 comments · Fixed by #729
Assignees
@ComfyFluffy

Comments

@nighca
Copy link
Collaborator

nighca commented Aug 9, 2024 •
edited
Loading

Now we use @monaco-editor/loader to load monaco-editor to support i18n. It tries to load assets from cdn.jsdelivr.net, e.g., https://cdn.jsdelivr.net/npm/monaco-editor@0.43.0/min/vs/loader.js.

While cdn.jsdelivr.net is blocked by GFW, which breaks code editor for users from Mainland China.

We may need to configure it to load assets from some other places to avoid GFW blocking.
@nighca nighca changed the title cdn.jsdelivr.net blocked by GFW cdn.jsdelivr.net blocked by GFW Aug 9, 2024
@ComfyFluffy ComfyFluffy mentioned this issue Aug 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ComfyFluffy ComfyFluffy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add monaco to public ComfyFluffy/builder
2 participants
@nighca @ComfyFluffy