-
-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Observation does not work on mac anymore: #797
Comments
I can confirm this via GitHub Actions. Run where only Mac doesn't produce any events: Source code: |
And a bisect:
Source code: |
This works for me locally, let's see what the CI machine says.
Hey, thanks for reporting this problem! Nevermind, I've found the problem. It seems the watch path is not fully normalised, and as such the recursive check fails to fully understand the usage of |
A watch path may be relative, while an event path is always absolute. Since the check for recursive events simply compared the watch path with the event path then that would fail in case the watch was set to a relative folder. This resolves the issue. Fixes gorakhargosh#797
…bserver (#799) * Add test for issue #797 This works for me locally, let's see what the CI machine says. * Use absolute watch path in recursive check A watch path may be relative, while an event path is always absolute. Since the check for recursive events simply compared the watch path with the event path then that would fail in case the watch was set to a relative folder. This resolves the issue. Fixes #797 * Add support for ~ in watch path Same problem as relative paths. * Update changelog.rst Co-authored-by: Mickaël Schoentgen <contact@tiger-222.fr>
Hi and thanx for this library.
I have an Observer that listens on *.json files:
And I create a simple test, that just creates a new File:
with watchdog 2.0.3 I get:
But with watchdog 2.1.1 no event is fired anymore.
Do I miss anything or is this a bug?
This issue does not arrive at ubuntu/bionic:
The text was updated successfully, but these errors were encountered: