Skip to content
This repository has been archived by the owner on Aug 8, 2021. It is now read-only.

Change API Endpoint #20

Open
mugman174 opened this issue May 6, 2021 · 10 comments
Open

Change API Endpoint #20

mugman174 opened this issue May 6, 2021 · 10 comments
Labels
enhancement New feature or request

Comments

@mugman174
Copy link

What do you want

I want to change the API endpoint for Gord's requests. Normally, Gord accesses discord's api at discord.com/api, but I want to be able to change that for use with Fosscord.

Why

It will allow compatibility with projects like litecord (not lightcord) and Fosscord.

Implementation hints

config file entry maybe

@yellowsink yellowsink added enhancement New feature or request needs-discordgo-fix labels May 6, 2021
@Bios-Marcel
Copy link

Bios-Marcel commented May 7, 2021

FYI this is already possible @cainy-a https://pkg.go.dev/github.com/cainy-a/discordgo#SetEndpoints

Just needs a config entry or CLI parameter

@yellowsink
Copy link
Collaborator

Oh ok awesome!

@Bios-Marcel
Copy link

Might want to make this a per session thing though, as accounts may want to connect to different backends or you may even support multiple parallel sessions that use the same interface. Taking #18 and this issue at the same time into account.

Right now this is package wide, so all session instances would use the same endpoints.
Would require some changes throughout discordgo though. Probably can cover most of it with a simple regex though.

@yellowsink
Copy link
Collaborator

that seems sensible yes

@yellowsink
Copy link
Collaborator

ig thats just an extra thing to store with the accounts array

@mugman174
Copy link
Author

Thx

@yellowsink
Copy link
Collaborator

Why'd you close this? It hasn't been implemented...

@yellowsink yellowsink reopened this May 9, 2021
@mugman174
Copy link
Author

Why'd you close this? It hasn't been implemented...

Idk I’m on my phone rn so probably misclicked

@yellowsink
Copy link
Collaborator

ok

@yellowsink
Copy link
Collaborator

i guess close with comment and comment are fairly close together on small screens

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants