Skip to content
This repository has been archived by the owner on Aug 8, 2021. It is now read-only.

Gord broke discord notifications #40

Open
j0lol opened this issue Jul 25, 2021 · 32 comments
Open

Gord broke discord notifications #40

j0lol opened this issue Jul 25, 2021 · 32 comments
Labels
bug Something isn't working

Comments

@j0lol
Copy link

j0lol commented Jul 25, 2021

How have you installed gord

Arch User Repository (the AUR)

What happened

I installed Gord on my mobile linux phone, and the wifi cut out. This resulted in Gord crashing and resulted in all Direct Messages not pushing notifications or notification sounds to any client. (discord, ripcord, etc) I have checked via Powercord plugin that there are no extra sessions connected, I have enabled 2FA, i have changed my password (my token has changed). Messages will show as unread on desktop client (with the red line) but not notify me in any visual way. This bug has been ongoing for about two days, and stays when the Gord client is closed and when its host device is powered off.

How do you reproduce this bug

  1. Have Gord open
  2. Have wifi (or modem?) disconnect

System information

Key Value
OS Arch Linux ARM
Architecture aarch64
Terminal st
@j0lol j0lol added the bug Something isn't working label Jul 25, 2021
@j0lol
Copy link
Author

j0lol commented Jul 25, 2021

real odd bug. i have never seen something like this in a client before....

@VMpc
Copy link

VMpc commented Jul 25, 2021

Ok I'm sorry for this EXTREMELY irrelevant comment but I would just like to say this is the "I use arch btw" phone edition (sorry not sorry)

@j0lol
Copy link
Author

j0lol commented Jul 25, 2021

lol yea,

@j0lol
Copy link
Author

j0lol commented Jul 25, 2021

to elaborate more: i get notifs for guilds completely fine, its just dms, and its all of my dms, not a specific person.
im going insane

@yellowsink
Copy link
Collaborator

  • Have you tried toggling notifications on an off in your discord client
  • Does re-opening then closing gord work (with no other clients open)

@yellowsink
Copy link
Collaborator

the "I use arch btw" phone edition

Lmao

@j0lol
Copy link
Author

j0lol commented Jul 25, 2021

* Have you tried toggling notifications on an off in your discord client

yea

* Does re-opening then closing gord work (with no other clients open)

yes, i get notifications from Gord itself, not other clients while gord is open
after closing gord, no notifications. notably, after closing gord with Ctrl-C i am stuck on a blank terminal with no way to get out than closing the terminal

in this state, the client is still connected, as seen here thanks to powercord:
image
after closing the terminal, the session is gone

@j0lol
Copy link
Author

j0lol commented Jul 29, 2021

update: this issue has not gone away, still very confused. may have to make a new discord account to avoid this

@yellowsink
Copy link
Collaborator

🤔 this is sooo strange

@TCCQ
Copy link

TCCQ commented Aug 3, 2021

Dumb question, but are you 100% sure that gord is properly closing? Flags are raised in my mind when you talk about blank terminals and ctrl-c not giving a clean exit. This seems to me to be a handshaking problem either with gord not closing, or with an invisible gord running headless somewhere. What do pgrep gord and whatnot return? Does being on a phone mean your terminal is something exotic?

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

weird. gord closes properly now. i ended up leaving gord for a few days while i troubleshooted the issue, now ive been back for a few days i dont have the weird broken exit problem
from what i recall it was still open until i forced it to close via bpytop

the current setup i have is kinda weird in terms of linux but not very weird in terms of phone linux.
it's arch linux arm with a window manager, on xorg and st terminal (because of course they package suckless) this is from what i understand to be pretty normal usage for st, albeit on a phone. its technically an st fork i guess

from what im seeing of this, this is a completely random, unproduceable error that flipped some ungodly flag in discord's db. its not something ive been able to undo, i have no idea how i would even begin to undo it with the tools we have, and i havent attempted reproducing it with a new account. (though i probably will)

as a last ditch effort, i might just give up and contact customer support, play dumb, and be at their will to terminate my account or somehow fix this problem

@yellowsink
Copy link
Collaborator

Hmm. I don't know what conclusion to draw from this... It's certainly an issue triggered by Gord in this case, but it appears to possibly coincide with some horrid super rare backend bug?

Very odd. I wonder if it was somehow triggered by an unclean exit from when Gord likes to crash st (#11)?

Unfortunately, st really hates Gord for some reason. To quote someone on Discord:

i usually install alacritty tho cuz sometimes st goes fucky wucky

Either way, I'm overdue saying that I'm extremely sorry that you've ended up with bricked notifs on your account due to my software, and I really hope you can find some resolution, be it with support or otherwise.

@yellowsink
Copy link
Collaborator

Dumb question, but are you 100% sure that gord is properly closing? Flags are raised in my mind when you talk about blank terminals and ctrl-c not giving a clean exit. This seems to me to be a handshaking problem either with gord not closing, or with an invisible gord running headless somewhere. What do pgrep gord and whatnot return? Does being on a phone mean your terminal is something exotic?

Gord always appears to close cleanly for me. demo
My best guess is EXTREMELY bad timing with a crash, possibly sending corrupt/malformed data to Discord.

@TCCQ
Copy link

TCCQ commented Aug 4, 2021

Dumb question, but are you 100% sure that gord is properly closing? Flags are raised in my mind when you talk about blank terminals and ctrl-c not giving a clean exit. This seems to me to be a handshaking problem either with gord not closing, or with an invisible gord running headless somewhere. What do pgrep gord and whatnot return? Does being on a phone mean your terminal is something exotic?

Gord always appears to close cleanly for me. demo
My best guess is EXTREMELY bad timing with a crash, possibly sending corrupt/malformed data to Discord.

tl;dr, I don't think we as users can do anything here, I think Discord would need to fix it, and I kind of doubt they will.

I agree, I haven't had any issues with gord not closing properly. The crash/malformed data theory makes sense to me. My only thought to the contrary would be that an 2fa enable or a password change would force a relogin on all current sessions, effectively killing the glitched "session" that is hogging the notifs. That is clearly not happening. Another point against the ghost session theory is that, at least for me, if I have gord and regular discord open, I get notifs from both, so I think we can dismiss this.

I am not sure I have a point in all of this. If I had to suggest something, a fine tooth comb over the notification settings and then giving up would be it. I would suggest against going to official support, I think that will just net you a user termination and if that is the goal, then you can just make a new account and save yourself some grief.

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

My only thought to the contrary would be that an 2fa enable or a password change would force a relogin on all current sessions, effectively killing the glitched "session" that is hogging the notifs.

yea, ive already discounted this as i have attempted both to no avail. i have also used tools to see if there are any logged in sessions

My best guess is EXTREMELY bad timing with a crash, possibly sending corrupt/malformed data to Discord.

I suggest that Gord check that before it terminates any data is sent in full and wait until its finished doing so. I dunno, maybe a cosmic ray hit my phone or something.

Either way, I'm overdue saying that I'm extremely sorry that you've ended up with bricked notifs on your account due to my software, and I really hope you can find some resolution, be it with support or otherwise.

Thanks for your condolenses, I'm not really sure where to go from here. I'm just real hesitant to make a new account, as discord accounts come with a lot of baggage and its not something I want to lose over a weird bug. The only other thing I can think of is to keep a constant third party discord client open for notifications, as they are unaffected by the bug (kinda hacky though, and it wouldnt work on the go that well)

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

related? https://www.reddit.com/r/discordapp/comments/owk80n/not_getting_any_dm_notifications/
https://www.reddit.com/r/discordapp/comments/mlerr0/no_dm_or_group_notifications/
it looks like support is not gonna help in the slightest, ive found the weird bug that they dont know how to fix

@ghost
Copy link

ghost commented Aug 4, 2021

this is 100% an improperly closed session

Personally I use a selfbot that is always running, and it makes notifications not appear on mobile and sometimes not on the desktop client. when i turn it off it's normal

That being said, force closing all open sessions by changing your password is worth a shot, as it can close the glitched session and should fix notifs if this is the problem

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

@binex-dsk i checked all sessions already, i have changed password and 2fa, i have closed all clients, i have done everything to invalidate a session like this

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

yea its all the markings of a discord session, but its nothing i can fix

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

maybe the server thinks i have a session open, but cant invalidate it because it doesnt exist
a 👻 ghost session 👻
idk talking to cancel of ripcord about this and this makes sense
image

no idea how i would even begin to fix this
close a session that doesnt even exist?

@ghost
Copy link

ghost commented Aug 4, 2021

Oh yeah thats almost certainly it, ghost session that doesn't exist but the server believes it does

since discord jannies probably won't help yeah you're probably fucked L

@j0lol
Copy link
Author

j0lol commented Aug 4, 2021

already going through the process of account hopping. lesson learnt, i guess? maybe? dont close a client improperly i guess

@yellowsink
Copy link
Collaborator

yellowsink commented Aug 4, 2021

Well it sucks that this happened but it does appear that you're screwed :\

Well if it happens again on the new account reopen this issue and we'll have to try and find out what in Gord is triggering it.

@TCCQ
Copy link

TCCQ commented Aug 6, 2021

Alright gamers, this issue may merit re-opening, as I too am now a victim of the exact same stuff.

To recap:
No DM notifs
Yes server notifs
gord crashed (enclosing terminal did not, not intentional ctrl-c)
like 90% sure that I was on a dm page when it happened
-> if gord works like normal discord, if you have the dm page up, then no notifs come in while that session is not timed out

All of this seems to lend credibility to the theory that this is a case of a ghost session.
A password change did not fix this problem, but did force a re-login on all my devices/sessions.
I am not planning to switch accounts, so if my account needs to be a experimental spot, we can probably make that happen.

All in all: This is a problem, but I am really not sure what we can do about it

@yellowsink
Copy link
Collaborator

Ah crap

@yellowsink yellowsink reopened this Aug 6, 2021
@ghost
Copy link

ghost commented Aug 6, 2021

we can fix crashes and test on dummy accounts

Alternatively we rewrite it in rust to get rid of those segfaults and bugs!

@TCCQ
Copy link

TCCQ commented Aug 7, 2021

I mean a full rewrite is often a good idea, but it seems a little heavy handed for a single bugfix. It kinda kills all work on anything else until it is done.

@j0lol
Copy link
Author

j0lol commented Aug 7, 2021

oh my god they got you too
welcome to the club

@j0lol
Copy link
Author

j0lol commented Aug 7, 2021

yea the same thing happened to both of us

@j0lol
Copy link
Author

j0lol commented Aug 7, 2021

i think to solve this we should aim to recreate this outside of gord.. aka making direct api calls... maybe when testing we can log all api calls to discord.

@TCCQ what arch were u running on? what terminal? latest version? distro/os?

@yellowsink
Copy link
Collaborator

yellowsink commented Aug 7, 2021

I mean a full rewrite is often a good idea

To be fair if I needed any proof that a rewrite was necessary it'd be window.go and also the chatview, but it would take a significant amount of time to do

@TCCQ
Copy link

TCCQ commented Aug 7, 2021

Arch linux Linux [user bleep] 5.13.7-arch1-1 #1 SMP PREEMPT Sat, 31 Jul 2021 13:18:52 +0000 x86_64 GNU/Linux
I believe the terminal was xterm, but I was also in progress of switching to urxvt, so it could have been that.
i3-wm (not gaps)
installed gord via the gord-git AUR package earlier that day, so the most recent version

The fact that both of these have happened if fairly quick succession makes me think it must be something in a fairly recent commit, but that could be totally random.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants