Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omitting .js in scriptlet names #235

Closed
8 tasks done
hawkeye116477 opened this issue Jun 11, 2020 · 9 comments
Closed
8 tasks done

Omitting .js in scriptlet names #235

hawkeye116477 opened this issue Jun 11, 2020 · 9 comments
Labels
question Further information is requested

Comments

@hawkeye116477
Copy link
Contributor

Prerequisites

  • I verified that this is not a filter issue
  • This is not a support issue or a question
  • I performed a cursory search of the issue tracker to avoid opening a duplicate issue
    • Your issue may already be reported.
  • I tried to reproduce the issue when...
    • uBlock Origin is the only extension
    • uBlock Origin with default lists/settings
    • using a new, unmodified browser profile
  • I am running the latest version of uBlock Origin
  • I checked the documentation to understand that the issue I report is not a normal behavior

Description

On uBO web-ext I can do for example belvederehotel.pl##+js(abort-on-property-read, pf_queen.push), so I can omit .js from scriptlet name, but seems that doesn't work with uBO Legacy.

@JustOff
Copy link
Collaborator

JustOff commented Jun 11, 2020

This is a known limitation of uBO legacy that skipping .js for long scriptlet names does not work you can only use the following options:

belvederehotel.pl##+js(abort-on-property-read.js, pf_queen.push)
belvederehotel.pl##+js(aopr.js, pf_queen.push)
belvederehotel.pl##+js(aopr, pf_queen.push)

These, however, cover all the syntaxes currently used in native uBO subscriptions, and I'm inclined to wantfix this issue, unless someone is going to take on the task of getting rid of the filter syntax converter and completely rewriting the parsing routine.

@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Jun 11, 2020

As I checked, seems that only first case which you mentioned works in my filters tab, but if case from my previous post is in the filterlist, then it's converted and works good.
However there are some other things not converted, so fine, I'll try to adapt to new shorter names in filterlists 😄

@JustOff
Copy link
Collaborator

JustOff commented Jun 11, 2020

my filters is a special case, see #228.

@JustOff JustOff changed the title Omitting .js in scriptlet names not working Omitting .js in scriptlet names Jun 12, 2020
@JustOff JustOff added the question Further information is requested label Jun 12, 2020
@JustOff JustOff closed this as completed Jun 12, 2020
@AroKol78

This comment has been minimized.

@JustOff

This comment has been minimized.

@AroKol78

This comment has been minimized.

@JustOff
Copy link
Collaborator

JustOff commented Dec 10, 2020

If something specific does not work, open a separate issue according to the proposed template.

@AroKol78

This comment has been minimized.

@krystian3w

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants