Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one.co.il is broken #1081

Closed
IsraeliUser opened this issue Dec 17, 2015 · 8 comments
Closed

one.co.il is broken #1081

IsraeliUser opened this issue Dec 17, 2015 · 8 comments

Comments

@IsraeliUser
Copy link

(Default filter sets with EasyList Hebrew)
On homepage, try to click on videos from ONE VOD.

You need to add to the unbreak list:
@@||google-analytics.com/ga.js$domain=one.co.il
@@||xads.zedo.com/ads2/c?*.one.co.il/Cat/Video/
The first one is caused by Peter Lowe's list. Second by uBlock Origin blocking method.

@gorhill
Copy link
Owner

gorhill commented Dec 17, 2015

Second by uBlock Origin blocking method.

I don't understand what that means. Can you explain?

@IsraeliUser
Copy link
Author

uBlock Origin has prevented the following page from loading:

http://xads.zedo.com/ads2/c?a=...

Because of the following filter

||zedo.com^

Found in: Peter Lowe’s Ad server list

But when I use Peter Lowe’s Ad server list on Adblock Plus I don't have this issue.

@gorhill
Copy link
Owner

gorhill commented Dec 17, 2015

With both (ABP or uBO) and Peter Lowe's and:

@@||google-analytics.com/ga.js$domain=one.co.il
@@||xads.zedo.com/ads2/c?*.one.co.il/Cat/Video/

I get:

Error loading playlist:
Error loading file

But when I use Peter Lowe’s Ad server list on Adblock Plus I don't have this issue.

I can't make sense of this. zedo.com is blocked by EasyPrivacy and Peter Lowe's, so the issue should also be present in ABP.

This is what I get re. zedo.com using http://www.one.co.il/Article/15-16/2,675,1219,0/262323.html:

a

@IsraeliUser
Copy link
Author

Do you use EasyList Hebrew? Many Israeli sites like this one are broken/blocked if you don't use it.
With ABP (using EasyList Hebrew) on Firefox I've no issue.
When I use Peter Lowe's list on ABP I need to add only the first filter to watch the videos.
With uBO I need both filters.

@gorhill
Copy link
Owner

gorhill commented Dec 17, 2015

Do you use EasyList Hebrew?

My bad, forgot to check it. So I am now further in having the video play, however it still does not play and nowhere in the log there is an instance of xads.zedo.com. Investigating.

@gorhill
Copy link
Owner

gorhill commented Dec 17, 2015

Alright, I could get the video to play, with the following steps:

  • Disable Flash plug-in -- such that the player falls back on using the HTML5 player.
  • Adding your filter @@||google-analytics.com/ga.js$domain=one.co.il.

Video plays from here, no need to allow connections to ad servers.

If enabling uBlock filters -- Experimental (which will override the above exception filter for google-analytics.com/ga.js) to really avoid connecting to google-analytics.js, there were exceptions thrown in the console, that is now fixed by adding the missing stuff into the neutered www.google-analytics.com/ga.js in redirection-resources.txt.

@IsraeliUser
Copy link
Author

Problem has not been solved yet.
On the main page, try to click on the videos in the light grey box "ONE VOD". You should get a blocking message. You should add the other filter as well. It won't whilelist any ad.

@gorhill
Copy link
Owner

gorhill commented Dec 17, 2015

I see, the link is going through xads.zdo.com before serving the expected content. I don't like that kind of 3rd-party tracking. At least users are made aware of this now, and this awareness would go away if I create a filter to bypass the warning -- so I rather not add this exception filter. One can even use the embedded URL in the parsed URL on the block page to skip completely xads.zedo.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants