Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox: block an element from the Web Inspector #119

Closed
tyaremco opened this issue Apr 25, 2015 · 8 comments
Closed

Firefox: block an element from the Web Inspector #119

tyaremco opened this issue Apr 25, 2015 · 8 comments
Labels

Comments

@tyaremco
Copy link

This is quite useful. I hope you'll consider pulling this in.

uBlock-LLC/uBlock@e8572bd

@d4k0
Copy link

d4k0 commented Apr 25, 2015

+1

@anewuser
Copy link
Contributor

@d4k0 on Github, avoid posting meaningless comments like "+1". The issue remains open until the developers have the time to implement the suggestion or close it for considering them innapropriate.

@gorhill if you add this, please add different toggles for showing this and the item in the main Firefox context menu. @chrisaljoudi's version uses the same "Make use of context menu where appropriate" checkbox for both things, which is an annoyance since I'm only interested in seeing it in the web inspector context menu.

@tyaremco
Copy link
Author

@anewuser "+1" is not meaningless. In this context it means "I would also like to see this feature implemented".

Until Github implements a system other than "issue participant total" to gauge the demand for a feature, a "+1" comment seems fine to me. A "+1" comment would only be redundant if the developer had already commented on his intentions to address the issue.

@anewuser
Copy link
Contributor

@tyaremco the developer is already aware of this issue no matter how many "+1" you keep adding to the page. It annoys people and adds clutter to our repo. Just wait. If the suggestion is decent, it's going to be implemented even if it has been only suggested by a single user.

If you're in a hurry for this feature, use @chrisaljoudi's version.

@tyaremco
Copy link
Author

@anewuser

the developer is already aware of this issue no matter how many "+1" you keep adding to the page.

As I'm sure you know, "+1" is about developer awareness of the demand for a feature not awareness of the feature itself.

If the suggestion is decent, it's going to be implemented even if it has been suggested by only a single user.

I consider this is a dubious statement. Of course, this is not the place for me to elaborate.

He has forked his own project not to see stuff like this anymore.

If gorhill has preferences about what stuff he doesn't want to see then he make them clear in CONTRIBUTING.md (which he has).

In fact, this is a borderline issue anyway as it's technically a feature request which he explicitly discourages. Because it's a already been implemented in the main repo, I thought he might be OK with it.

@gorhill
Copy link
Owner

gorhill commented Apr 27, 2015

"+1" makes absolutely no difference on whether or not I want to implement something. What makes a difference is whether I believe I should work on it considering every else, "every else" being all other issues and shortcomings of uBlock which also need to be addressed, including some which nobody is plus-one'ing.

@sn260591
Copy link

sn260591 commented Jun 3, 2015

@gorhill is there any news on this?

@gorhill
Copy link
Owner

gorhill commented Jun 3, 2015

I want to implement this in a portable way. Since it was implemented on Firefox, I did write prototype code to make this work for Chromium, and I did not like the result. I am thinking of other approaches to accomplish the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants