-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Element picker wont open #3286
Comments
Unable to reproduce. You will have to investigate on your side, there is something specific on your side causing this. |
Consider investigating your browser settings you may have changed, including your |
Closing as per CONTRIBUTING. Read carefully 1st paragraph please. |
I apologies, I have read the CONTRIBUTING, multiple times. But I have no clue how to give you more information. The console gives nothing. I found how to open the debugger, but it doesn't throw me an error when I try to open the element picker. I do get errors, but nothing that is helpful.
But nothing when I try to open the element picker. So it either doesn't send a request at all when I try to open the element picker, or the debugger doesn't show that action. This was a fresh install of windows 10, and is a fresh install with new profile of Firefox. So no changes has been made. uBlock 1.14.16 works, so that is a way to bypass this (it has other problems, but works as long as I don't clear the cache). I'm asking around where I can find better debug tools. I thought that the Firefox debug tool showed everything that the addon is doing, but that was my fault for assuming. I will report back once I find a tool that tells me what is happening. |
Does it work on other web pages or is only |
Also, can you report how many cosmetic filters are in currently loaded in memory in the 3rd-party filters pane in the dashboard? |
Output of uBO's logger would be good also for when you load the page. |
It affect all sites I tried on, I have no way to open the element picker on 1.14.18 Currently I disabled every filter so I can easier debug. logger,
Version 1.14.16 can open the element picker, not with the right click menu, but with the "Enter element picker mode" button on the icon. It however also doesn't show anything happening in the debugging tool. |
Well, that is your issue: #2963. |
I did not know the element picker get disabled when no filters are active. Shouldn't debug with filters of then. But even with filters on it dosn't work.
logger,
cosmetic filtering is on. |
You said in your opening comment that you use "Default filter lists" and no custom filters. If so, there is just no way you will end up with that many filters:
|
Yes, that was with most filters on. With the default settings I have with the logger
|
Open the browser console (ctrl-shift-j) and see if errors are reported when you try to launch the element picker. |
In ctrl + shift + k (console) with all logging on, it says nothing. ctrl + shift + j (browser console) with all logging on, only gives me reflow when I press anything. |
Is the picker |
So I read about DOM. If you are talking about the "Inspector" where the is? If so then I did not find it. However, in version 1.14.16 where the element picker does work, I also didn't find it. Sorry, but I know nothing about web development. I do believe that the element picker doesn't load properly. Can I manually try and force to load it? |
Sorry, I don't know what else to say. Element picker seems to be working for everybody but you. At this point I am out of idea, you will need someone with dev skills looking in person at your own installation of Firefox. |
Ok, that's fine. 1.14.16 works so I can rollback whenever I want to use it. And as you said, seems like it's only I who have this problem. But I do appreciate the help, so thank you. And thanks for creating this addon. |
Note that I don't have FF58, I test on FF57 or FF59. Given that it works on both on my side, I am assuming there is no reason it should not work on FF58. I might give it a try just in case. Edit: never mind my comment above, you said "does not work on Firefox 56, 57". |
Ok, I found a solution. I don't know why, but it works. These filters cannot be active.
If I ever enable any of the said filters, I must disable it, "Purge all caches", then delete the current profile Firefox cache. And it should work. If I install fresh UBO i need to do the same, but the filter should already be deactivated, so just purge the cache and delete the Firefox cache. There is nothing inside the filters that break the element picker. I opened them and added the rules to "My Filters", and the element picker still works. But I don't know why it breaks by activate them. |
How much free space is there on your storage on which your Firefox is installed? |
it is on my main C:\ SSD that has 19 GB free space, I also have 16 GB DDR3 RAM and using 3 GB, Firefox is using 1,7 GB RAM. It's on Firefox x64 |
Describe the issue
Element picker wont open in Firefox 58.0b6 (64-bit) and uBlock origin 1.14.18. Works fine in 1.14.16.
One or more specific URLs where the issue occurs
All sites but testing on www.Google.se
Screenshot in which the issue can be seen
The buttons I'm pressing to try to enter element picker mode
https://i.imgur.com/rAhp7Rs.jpg
Steps for anyone to reproduce the issue
or
Your settings
Clean install of uBlock with default settings except enable advanced user.
Your filter lists
Default filter lists
Your custom filters (if any)
None.
Note
Does not work on Firefox 56, 57, or 58, does work in Chrome Version 62.0.3202.75 (Official Build) (64-bit). Tried to only have uBlock enabled.
Not sure how to give you any more info as I found no debug log, and the logger shows nothing when I try to open the element picker.
The text was updated successfully, but these errors were encountered: