Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact address blocking not working #400

Closed
vaindil opened this issue Jun 25, 2015 · 6 comments
Closed

Exact address blocking not working #400

vaindil opened this issue Jun 25, 2015 · 6 comments

Comments

@vaindil
Copy link

vaindil commented Jun 25, 2015

  • Windows 8.1, x64
  • Chrome stable, 43.0.2357.130 (32-bit)
  • uBlock version: 0.9.9.2

I'm using the rules at the bottom of this issue to attempt to block a specific address (my reddit user page, as an example), but the page is not being blocked. I do not see anything on the relevant wiki page that would preclude the ABP rule from working, so I'm not sure what's wrong.

Rules I'm using (in the My Filters section):

|reddit.com/u/icefall5|
|www.reddit.com/u/icefall5|
|reddit.com/user/icefall5|
|www.reddit.com/user/icefall5|
|http://reddit.com/u/icefall5|
|http://www.reddit.com/u/icefall5|
|http://reddit.com/user/icefall5|
|http://www.reddit.com/user/icefall5|
|https://reddit.com/u/icefall5|
|https://www.reddit.com/u/icefall5|
|https://reddit.com/user/icefall5|
|https://www.reddit.com/user/icefall5|
@gorhill
Copy link
Owner

gorhill commented Jun 25, 2015

but the page is not being blocked

Whole pages are blocked if and only if the filter matches only the hostname part of the URL (reference: uBlock-LLC/uBlock#1128). So strict blocking applies to whole sites, not specific pages on a site. This is because ABP-compatilble filter lists were not created with the blocking of whole pages in mind, and allowing strict blocking to block for any kind of filters causes way too many false positives. So the compromise is to block whole sites, such as all those from malware lists.

Closing as "by design".

@gorhill gorhill closed this as completed Jun 25, 2015
@gorhill
Copy link
Owner

gorhill commented Jul 13, 2015

Fixed with fa4e3ca.

Proper syntax for current case:

||reddit.com/user/icefall5|$document

Actually, duplicate of #192.

@harshanvn
Copy link

So, this is part of strict blocking functionality? And now we will allow to block specific pages instead of just domains. This is really great news and nice addition!
If so, i think this might deserve to have an update in Release Notes and in Wiki section..
Another feature ublock and ABP like are missing..

@gorhill
Copy link
Owner

gorhill commented Jul 13, 2015

So, this is part of strict blocking functionality?

I figure this was needed if I wanted to warn about tucows.com/downloads, which is cited in a couple of places as being one of the worst when it comes to badware.

@neilishere
Copy link

Does this change? https://github.com/gorhill/uBlock/wiki/Filter-syntax-extensions#not-supported

Are static lists now given the ability to make exceptions - and override our filters? like ABP?

@gorhill
Copy link
Owner

gorhill commented Jul 13, 2015

Does this change?

No, the document filter option is still ignored for exception filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants