Closing the logger asks Firefox if I want it to close all tabs

[SW1FT]

Self-explanatory title, I'm guessing this behavior is not intended.
You need to launch the logger from the uBlock Origin popup panel, not from the Options on about:addons as it will open the logger in a new tab rather than a new window.
I'm running Firefox 40.0a2 and uBlock Origin 0.9.9.3-dev.5 on Windows 7.

[gwarser]

On Fx 39 FEBE extension show me dialog:

Backup on shutdown is ready to run

[Betsy25]

Self-explanatory title.
I'm running Firefox 40.0a2 and uBlock Origin 0.9.9.3-dev.5 on Windows 7.

Cannot reproduce here on FF 40.0a2 & UblockO 0.9.9.3-dev5 (Win7-x64)

[SW1FT]

@Betsy25 From where did you launch the logger?

[gorhill]

I'm guessing this behavior is not intended

No it's not. I can't reproduce, and I see nothing in the doc related to this. Firefox interpreting the closing if a single window as the user asking to close all windows is weird.

[SW1FT]

Weird, if you enable the DOM Inspector, when you close the window you don't get the prompt asking if you want to close all tabs.

EDIT: Tried again, actually it does prompt. But I tried it and it didn't like 30 seconds ago.

[gorhill]

Ok, I could reproduce if:

• I set default web page at start to "Show a blank page"
• I have at least two (unpinned) tabs opened in the main window
• And of course, "Warn me when closing multiple tabs" has to be checked

In such case, closing the logger will cause the warning to appear. Agreeing to the warning, the logger window close, and the main window is left open -- as expected. So this is really a spurious warning by the browser, as it did not result in all tabs closing as we are led to believe.

[SW1FT]

So this is a browser bug rather than a uBlock Origin bug?
EDIT: Is there another method of opening a new window to show the logger, so it doesn't bug out and say that you'll close all tabs if you close the logger?

[gorhill]

So this is a browser bug rather than a uBlock Origin bug?

I would think yes, since clicking Quit at the warning box does not in fact cause the browser to quit.

[gorhill]

Note that if I manually detach a tab in a separate window, the warning does not occur... So maybe there is a specific set of features a window must have in order for the warning to not appear... I will fiddle around.

[gorhill]

Using uBlock's own background window object fixes the issue.

[SW1FT]

The latest dev version didn't fix it for me.

[gorhill]

The latest dev version didn't fix it for me

So this means that my repro steps had nothing to do with your case. What are your Firefox settings in the General pane?

[SW1FT]

What the patch did was, instead of the logger launching in a new window, it launches in a new tab again.

Settings are:

• Open new window in a new tab (this explains the new behavior)
• Do not load tabs until selected

Since I have my FF in Portuguese, those settings most likely aren't written exactly that way.

[gorhill]

What about:

• When Firefox starts [ ... ]
• Warn me when closing multiple tabs

[SW1FT]

I don't know where that setting is located at. However, if I have multiple tabs open it does warn me when I try to close FF.

[gorhill]

I had assumed that since I could reproduce with Linux, the fix for Linux would work on Windows, so I had not tested on Windows. But I confirm it does not work for Windows.

[gorhill]

I added details of the current issue to a Firefox bug which matches the problem here: https://bugzilla.mozilla.org/show_bug.cgi?id=644224.

[SW1FT]

Probably will never be fixed, it was reported 4 years ago and the comment before yours is also from that time.