Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BottomSheetContainer): cannot add new property 'value' #1808

Merged

Conversation

MoritzCooks
Copy link
Contributor

Motivation

Currently the v4 faces the issue cannot add new property 'value' (have a look at #1292 and #1293)
Those were automatically closed without fixing the issue.

To fix that issue, BottomSheetContainer.tsx has to check if containerOffset.value is available.

@MoritzCooks
Copy link
Contributor Author

One more try 😄
You will not get rid of me @gorhom !

@MoritzCooks
Copy link
Contributor Author

My two previous PRs got automatically closed:

Please have a look at it. It's just one line to prevent a potential undefined containerOffset which happens in some cases.

@gorhom gorhom self-requested a review April 19, 2024 13:08
@gorhom gorhom merged commit e294d1c into gorhom:master May 19, 2024
@gorhom
Copy link
Owner

gorhom commented May 19, 2024

thanks for your contribution ,, i apologise for merging late

gorhom pushed a commit that referenced this pull request May 19, 2024
…MoritzCooks)

* fix(BottomSheetContainer): `Cannot add new property 'value'` issue

* fix(BottomSheetContainer): upload lib

* Revert "fix(BottomSheetContainer): upload lib"

This reverts commit 5ab27b6.

---------

Co-authored-by: MoritzCooks <moritz.weiss95@hotmail.de>
@MoritzCooks
Copy link
Contributor Author

thanks for your contribution ,, i apologise for merging late

No worries 🙂

@MoritzCooks MoritzCooks deleted the fix/cannot-add-new-property-value branch August 5, 2024 11:28
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants