fix(BottomSheetContainer): cannot add new property 'value' #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One more try 😄 |
|
My two previous PRs got automatically closed:
Please have a look at it. It's just one line to prevent a potential undefined |
|
thanks for your contribution ,, i apologise for merging late |
gorhom
pushed a commit
that referenced
this pull request
May 19, 2024
…MoritzCooks) * fix(BottomSheetContainer): `Cannot add new property 'value'` issue * fix(BottomSheetContainer): upload lib * Revert "fix(BottomSheetContainer): upload lib" This reverts commit 5ab27b6. --------- Co-authored-by: MoritzCooks <moritz.weiss95@hotmail.de>
No worries 🙂 |
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the v4 faces the issue
cannot add new property 'value'(have a look at #1292 and #1293)Those were automatically closed without fixing the issue.
To fix that issue,
BottomSheetContainer.tsxhas to check ifcontainerOffset.valueis available.