Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] BottomSheetScrollView and BottomSheetBackdrop blocking the entire app content #242

Closed
ferrannp opened this issue Jan 28, 2021 · 9 comments
Assignees
Labels
bug Something isn't working v3 Written in Reanimated v2

Comments

@ferrannp
Copy link

ferrannp commented Jan 28, 2021

Bug

When mounting the sheet, it seems that the BottomSheetBackdrop is capturing your clicks and you cannot interact with the app.

It seems to happen only on iOS.

Environment info

Library Version
@gorhom/bottom-sheet 3.2.1
react-native 0.63.4
react-native-reanimated 2.0.0-rc.2
react-native-gesture-handler 1.9.0

Steps To Reproduce

Clone https://github.com/ferrannp/bottom-sheet-playground.

  1. Click Open button to open the sheet
  2. If it works, refresh JS and try again (does not work 90% of the times)

Describe what you expected to happen:

  1. To not block the app content

Reproducible sample code

https://github.com/ferrannp/bottom-sheet-playground

@ferrannp ferrannp added the bug Something isn't working label Jan 28, 2021
@gorhom gorhom self-assigned this Jan 28, 2021
@gorhom gorhom added the v3 Written in Reanimated v2 label Jan 28, 2021
@gorhom
Copy link
Owner

gorhom commented Jan 28, 2021

thanks @ferrannp for submitting this issue, will investigate it tomorrow 👍

@hoangtrung99
Copy link

@gorhom I have an error with BottomSheetBackdrop, BottomSheetBackdrop not visible when set dismissOnPanDown={true} in BottomSheetModal :/

@ferrannp
Copy link
Author

@gorhom let me know if you want me to try something for this one. Happy to help.

@gorhom
Copy link
Owner

gorhom commented Jan 29, 2021

yes please,, you could try to replace the Touchable component with TapGestureHandler in the BottomSheetBackdrop and see if it fix the issue :)

@ferrannp
Copy link
Author

ferrannp commented Jan 29, 2021

@gorhom: Mmm it seems that changing:

<AnimatedTouchableWithoutFeedback
  onPress={handleOnPress}
  ...
>

to

<TapGestureHandler
  onHandlerStateChange={handleOnPress}
  ...

Makes it work. However, the backdrop flashes remains in v3.

@gorhom
Copy link
Owner

gorhom commented Jan 29, 2021

@ferrannp would please test #246 :)

could you create a separate issue and i'll pick it right away 👍

@ferrannp
Copy link
Author

ferrannp commented Feb 1, 2021

Here you go @gorhom #250. Same repo with some tweaks.

@gorhom gorhom closed this as completed Feb 9, 2021
@phuoc-insignia
Copy link

@gorhom I have an error with BottomSheetBackdrop, BottomSheetBackdrop not visible when set dismissOnPanDown={true} in BottomSheetModal :/

try to set disappearsOnIndex={-1} on your <BottomSheetBackdrop /> component

@hoangtrung99
Copy link

@gorhom I have an error with BottomSheetBackdrop, BottomSheetBackdrop not visible when set dismissOnPanDown={true} in BottomSheetModal :/

try to set disappearsOnIndex={-1} on your <BottomSheetBackdrop /> component

Yes, it works, i did it before 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v3 Written in Reanimated v2
Projects
None yet
Development

No branches or pull requests

4 participants