Curseforge opted-out mods “Checking if the site connection is secure” is not given enough time to properly finish

[tanchevk]

• I searched the issue tracker for other issues covering my case
• This is a Launcher issue. (Usually if you can reproduce it with a fresh instance)

Describe the bug
When installing modpacks and/or mods, curseforge sometimes mandates a connection check, courtesy of Cloudflare. When this occurs, GDlauncher falsely assumes nothing is wrong and refreshes the page after a given amount of time, however this interferes with the connection check and results in an infinite loop of GDlauncher trying to download the opted-out mod but being unable to properly verify its connection.

To Reproduce
Steps to reproduce the behavior:

1. Open GDlauncher
2. Click on the new instance button
3. Select modpacks (easiest way to witness, also works with mods)
4. Select any modpack with opted-out mods (for example, Light Craft)
5. Wait for opted out mods modal
6. Click confirm
7. Observe as GDlauncher enters an infinite loop of verification attempts
8. After a given amount of attempts, GDlauncher will simply inform you of a failed download

Expected behavior
GDlauncher should, optimally, allot more time for the verification prompt (this one doesn't even require input)

Possible solutions
Detect this page (utilizing request and response headers, maybe) and increase the time between refreshes when it detects the verification prompt

Screenshots


(Ignore background applications, forgot to close)

Operating System:

• OS: Windows 11 Home 22H2 22621.1105
• Launcher Version: v1.1.25
• Java Version: 19
• Minecraft Version: 1.19.3 (observed on other versions as well)
• Mod Loader: Fabric (occurs on Forge also)

[Eskaan]

Duplicate of #1513
Also, the latest version is v1.1.29 / v1.1.30-beta.1 ;)

[tanchevk]

oops mb my dumb ass forgot to update