Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regression in vars extract for wildcard host #579

Merged
merged 1 commit into from
Jul 11, 2020
Merged

fix: regression in vars extract for wildcard host #579

merged 1 commit into from
Jul 11, 2020

Conversation

harshavardhana
Copy link
Contributor

Continuing from PR #447 we have to add extra
check to ignore the port as well

@harshavardhana
Copy link
Contributor Author

// cc @elithrar

@elithrar
Copy link
Contributor

Can you please add regression tests that capture this change? :)

@harshavardhana
Copy link
Contributor Author

@elithrar let me look at those - thanks for quickly looking at the PR.

@harshavardhana
Copy link
Contributor Author

would it be possible to make a release today if all goes well? @elithrar

@harshavardhana harshavardhana mentioned this pull request Jul 10, 2020
Merged
7 tasks
@elithrar elithrar self-requested a review July 10, 2020 17:47
@elithrar elithrar self-assigned this Jul 10, 2020
@elithrar elithrar added the bug label Jul 10, 2020
@elithrar
Copy link
Contributor

I'll commit to having this reviewed before the end of the weekend.

@harshavardhana
fix: regression in vars extract for wildcard host
8769a15 
Continuing from PR gorilla#447 we have to add extra
check to ignore the port as well

add tests to cover this case
@harshavardhana
Copy link
Contributor Author

@elithrar updated the PR with the tests, the same tests don't run with master branch.

elithrar
elithrar approved these changes Jul 11, 2020
View reviewed changes
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: push a release / note this as a subtle behavior change

@elithrar elithrar merged commit 98cb6bf into gorilla:master Jul 11, 2020
@harshavardhana harshavardhana deleted the fix-hosts branch July 11, 2020 20:12
@harshavardhana
Copy link
Contributor Author

Possible to tag a release @elithrar ?

@harshavardhana
Copy link
Contributor Author

Possible to tag a release @elithrar ?

checking back to see if there can be a tagged release? @elithrar

@elithrar
Copy link
Contributor

https://github.com/gorilla/mux/releases/tag/v1.8.0

@harshavardhana harshavardhana mentioned this pull request Aug 22, 2020
Merged
6 tasks
This was referenced Mar 11, 2021
Closed
Open
@odeke-em odeke-em mentioned this pull request Sep 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elithrar elithrar elithrar approved these changes

Assignees

@elithrar elithrar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshavardhana @elithrar