Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema to schemastore.org for integration into VSCode #811

Open
lox opened this issue May 30, 2023 · 5 comments
Open

Add JSON schema to schemastore.org for integration into VSCode #811

lox opened this issue May 30, 2023 · 5 comments

Comments

@lox
Copy link

lox commented May 30, 2023

Describe the feature:

Since there is now a JSON schema (#793) would be great to have it mapped to goss.yml files via Schema Store. This would mean that folks using editor plugins like https://github.com/redhat-developer/vscode-yaml would immediately get validation for their goss files.

Describe the solution you'd like
Reference the JSON Schema via https://github.com/SchemaStore/schemastore/blob/master/CONTRIBUTING.md#catalog (happy to do this if there is interest)

Describe alternatives you've considered
Manual editor configuration.

@aelsabbahy
Copy link
Member

@gberche-orange and @ripienaar any thoughts on this?

@lox for my own clarity, it seems the actual PR would be to the schemastore repo, not Goss, correct? Or is there something needed to be also done here.

@ripienaar
Copy link
Collaborator

This would be a great addition.

@aelsabbahy
Copy link
Member

Heads up, v0.4.0 release candidate just went out. It may impact some of the schemas that were written up.

Please let me know if you have any questions.

@gberche-orange
Copy link
Contributor

gberche-orange commented Jul 24, 2023

thanks @aelsabbahy ! I'll try updating the json schema against https://github.com/goss-org/goss/releases/tag/v0.4.0-rc.1 and propose a unit tests for future regressions in goss-org/goss, either this week or more likely early September when I some available time. Anyone feel free to tackle this earlier if some bandwidth is available earlier. After that, we can get a PR on schemastore, possibly versioned if there is need to account for breaking changes in syntax in 0.4

@hinricht
Copy link

I wonder if this ticket could be closed, since the goss schema is vailable at https://www.schemastore.org/json/ already ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants