Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make test doesn't work #21

Closed
bigfatbird opened this issue Nov 27, 2023 · 15 comments
Closed

make test doesn't work #21

bigfatbird opened this issue Nov 27, 2023 · 15 comments

Comments

@bigfatbird
Copy link

While trying out compiling the macOS client on my machine building the libs and bindings correctly didn't work

Some errors were found while running

make test

in gosub-engine/gosub-bindings

Screenshot 2023-11-27 at 16 01 34
@Kiyoshika
Copy link
Member

can you also paste the output of “gcc -v” (should be an alias to apple clang on macs)

@bigfatbird
Copy link
Author

Apple clang version 15.0.0 (clang-1500.0.40.1)
Target: arm64-apple-darwin23.1.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin

@Kiyoshika
Copy link
Member

You said you are on silicon now? (But previously intel)

@bigfatbird
Copy link
Author

Yes. Bought the Mac in 2022 and migrated from an Intel with Migration Assistant.

@Kiyoshika
Copy link
Member

Hmm, so when you migrated did it also migrate your rust compiler? I wonder if completely reinstalling rust/rustup will help

@bigfatbird
Copy link
Author

I only added rust recently via rustup

@Sharktheone
Copy link
Member

I've heard somewhere, that the apple terminal sometimes runs via rosetta. So probably you need to disable it and then your termial runs with arm64 and not with x86_64.

@bigfatbird
Copy link
Author

LOL, wtf... will try tomorrow.

@Kiyoshika
Copy link
Member

yeah, that's odd. I have two macbooks but they are the same arch (arm64) so I can't test one with intel...

honestly I'm not sure what to do at this point lol, it seems to work for both of my laptops and Shark/Eric (both on Linux). Something odd must've happened with the migration

@Sharktheone
Copy link
Member

Sharktheone commented Nov 28, 2023

Found it... Maybe it helps for figuring out, what to do. modular/max#1078. It's for another repository, but the steps should probably be the same.

@bigfatbird
Copy link
Author

Jeez... Thanks for the hint, I will try to reinstall homebrew... in hope of not fucking up any of my other workflows...

@Kiyoshika
Copy link
Member

Just curious, did you ever get this to work?

@bigfatbird
Copy link
Author

I will try tomorrow

@Kiyoshika
Copy link
Member

Kiyoshika commented Dec 2, 2023

ok, the process has also been simplified as of this morning. You should now only have to clone this repo (with --recurse-submodules) and run make. You won't need to build/copy anything yourself anymore

@bigfatbird
Copy link
Author

It works now.

Somehow my rust-compiler was not migrated from intel to apple silicon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants