Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorthand resolve does not work for complex properties like background and border-radius #650

Open
Sharktheone opened this issue Oct 24, 2024 · 0 comments

Comments

@Sharktheone
Copy link
Member

The problem is in our shorthand resolver here: https://github.com/gosub-io/gosub-engine/blob/main/crates/gosub_css3/src/matcher/shorthands.rs

border-radius has the problem that it's syntax looks like this:

<length-percentage [0,∞]>{1,4} [ / <length-percentage [0,∞]>{1,4} ]?

We first have one to four lengths, this is fine. But then optionally it has a / followed by again one to four lengths. The current logic would know how to resolve the first part, for the second part it is a bit more difficult, since it needs to be again resolved to the same properties as the first one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant