Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fetcher away from the load_html_rendertree_fetcher, and create it at the calling function instead. #732

Open
jaytaph opened this issue Dec 24, 2024 · 0 comments
Labels
render tree Any issues related to the Render Tree data structure

Comments

@jaytaph
Copy link
Member

jaytaph commented Dec 24, 2024

See discussion: #730 (comment)

I think this should be removed, instead callers should create their fetcher by themselves and give it load_html_rendertree_fetcher.

This function creates the fetcher, use it and returns it.. instead we probably want to have the calling function to create the fetcher for more flexibility:

let fetcher = fetcher::new();
let render_tree = load_html_rendertree(url, None, fetcher);
@jaytaph jaytaph added the render tree Any issues related to the Render Tree data structure label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
render tree Any issues related to the Render Tree data structure
Projects
None yet
Development

No branches or pull requests

1 participant