Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go1.14: junit test result contains unrelated error message from t.Log #128

Closed
chaodaiG opened this issue Jun 9, 2020 · 3 comments
Closed
Labels
test2json-bug A bug in test2json which impacts gotestsum

Comments

@chaodaiG
Copy link

chaodaiG commented Jun 9, 2020

Starting go1.14, t.Log starts to stream during test run instead of at the end, this has caused interleaved logs when t.Parallel is configured, thus the error messages in junit results contain lots of unrelated logs from other tests.

See an example here: https://prow.knative.dev/view/gcs/knative-prow/pr-logs/pull/knative_serving/8274/pull-knative-serving-integration-tests/1270397344797429763

@dnephin
Copy link
Member

dnephin commented Jun 9, 2020

Thank you for the bug report!

This is an issue in go1.14, see golang/go#38458. It was fixed recently, so it should be resolved in go1.15. I wasn't able to find any way to work around the issue.

@chaodaiG
Copy link
Author

chaodaiG commented Jun 9, 2020

Great to know. Thanks for the pointer!

@dnephin
Copy link
Member

dnephin commented Mar 27, 2021

So far Go 1.15 and 1.16 seem to be working well, so I'm going to close this issue now.

@dnephin dnephin closed this as completed Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test2json-bug A bug in test2json which impacts gotestsum
Projects
None yet
Development

No branches or pull requests

2 participants