Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading List Wrong Order #1803

Closed
5 tasks done
falo2k opened this issue Dec 21, 2024 · 10 comments
Closed
5 tasks done

Reading List Wrong Order #1803

falo2k opened this issue Dec 21, 2024 · 10 comments
Labels
bug Something isn't working released

Comments

@falo2k
Copy link

falo2k commented Dec 21, 2024

Steps to reproduce

I have one reading list that, when loaded, keeps coming out in the wrong (consistently wrong) order in both the UI and OPDS feed. Weirdly, the order is correct both when initially doing the matching for import, and if I download the list once created (i.e. the prefix index numbers for each issue in the zip matches the original list order).

The list: https://github.com/DieselTech/CBL-ReadingLists/blob/main/Marvel/Teams/X-Men/Age%20of%20Krakoa/Age%20of%20Krakoa%20-%20Eras%20Lists/%5BX-Men%20Krakoa%202.5%5D%20Destiny%20of%20X%20Before%20the%20Fall.cbl

Here are some screenshots to illustrate the problem at various steps.

Illustration of the top of the CBL order:
chrome_2024-12-21_12-06-00

Import and matching in correct order
2024-12-21_12-06-06

Logs in correct order (0CAEMGEN9ACMZ is the id of X-Force #37, first in the list):
cmd_2024-12-21_12-09-56

UI Out of Order:
chrome_2024-12-21_12-07-14

I'm struggling to see a pattern of why it's doing this (and doesn't with any other list). I've tried reuploading it as a different name, from a new file, etc. In some cases it's bundling together issues from the same series that aren't consecutive in the list (e.g. Invincible Iron Man), but others it does not (Betsy Braddock: Captain Britain). That could just be me seeing a pattern where randomness exists.

Expected behavior

Once imported, the list should retain manual ordering and be displayed in the original order presented.

Actual behavior

The list is consistently displayed in the wrong order, through the UI and OPDS. It is always the same wrong order.

Logs

No response

Komga version

1.51.1

Operating system

Unraid

Installation method

Docker

Other details

No response

Acknowledgements

  • I have searched the existing issues (open AND closed) and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I have checked the FAQ.
  • I have updated the app to the latest version.
  • I will fill out all of the requested information in this form.
@falo2k falo2k added the triage label Dec 21, 2024
@falo2k
Copy link
Author

falo2k commented Dec 21, 2024

Log
komga.log

@falo2k
Copy link
Author

falo2k commented Dec 21, 2024

Noticed while browsing around that the cover image for the reading list does seem to represent the correct issue order as well.

image

@declankenny
Copy link

I came here to create this same issue. I as seeing the exact same thing with a reading list that I am trying to create. I can provide logs, sql queries and screenshots as required, but those will be the same as described above.

@declankenny
Copy link

Interesting to note: If I open the ui page for a book (https://mysite/book/0J3W33S13BWYD?context=READLIST&contextId=0J8PS8J0571F7) and use the navigation buttons on the top right - those do respect the actual order as recorded in the database, even though the thumbnail view is showing an incorrect order.

@falo2k
Copy link
Author

falo2k commented Dec 21, 2024

Got someone else on the reading list discord to try it and they also have issues. Here's another list I've found it happening with - link to commit as it's going to get deleted from the repo at some point. It will have content overlap with my first example.

https://github.com/DieselTech/CBL-ReadingLists/blob/ee5fa93708d7db38407c4ba93583dbb45a4bdeb3/Marvel/Teams/X-Men/Age%20of%20Krakoa/Age%20of%20Krakoa%20-%20Eras%20Lists/%5BX-Men%20Krakoa%202.5%5D%20Before%20the%20Fall.cbl

@falo2k
Copy link
Author

falo2k commented Dec 21, 2024

Just reverted to 1.41.1 and the lists (with no re-importing) started presenting in the correct order. Rolling forward to 1.50.0 and they lose it again, so that may narrow down the search.

@declankenny
Copy link

declankenny commented Dec 21, 2024

I think I can narrow down the issue even further. For me it is appears to only happening with books that are in multiple reading lists.
My guess is that the query that is being used for the UI rendering order is not respecting the current reading list and is somehow getting sequence numbers from the other lists.

@falo2k
Copy link
Author

falo2k commented Dec 21, 2024

That is a good spot. Again, could be bogus pattern recognition on my part, but the misordering for chunks of the first list aligns very closely with the order used in an alternative list of the same event. That also might explain why it's wrong in a consistent fashion. There is an order it's adhering to, just the wrong data.

@falo2k falo2k changed the title Reading List Random Order Reading List Wrong Order Dec 22, 2024
@gotson gotson added bug Something isn't working and removed triage labels Jan 2, 2025
@gotson
Copy link
Owner

gotson commented Jan 2, 2025

I think I can narrow down the issue even further. For me it is appears to only happening with books that are in multiple reading lists. My guess is that the query that is being used for the UI rendering order is not respecting the current reading list and is somehow getting sequence numbers from the other lists.

thanks for narrowing it down for me, i managed to reproduce the issue and will look into it.

Copy link
Contributor

github-actions bot commented Jan 2, 2025

🎉 This issue has been resolved in 1.16.0 (Release Notes)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

3 participants