Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create exact synonym from the GitHub issue somehow gets parsed as createexactsynonym in kgcl-java. #5

Closed
hrshdhgd opened this issue Aug 28, 2024 · 3 comments

Comments

@hrshdhgd
Copy link

Error:

2024-08-28 18:15:50,063 ERROR org.incenp.obofoundry.kgcl.robot.ApplyCommand - KGCL syntax error: line 1, column 45: no viable alternative at input 'createexactsynonym'ocean basin floor'for'ocean floor''

Issue that highlighted the error: EnvironmentOntology/envo#1518

GH Action: https://github.com/EnvironmentOntology/envo/actions/runs/10602157613/job/29383593707

kgcl-java version: 0.3.2 (need to update and have a PR for ENVO ready)

@gouttegd : are the single quotes in the command messing up something?

@gouttegd
Copy link
Owner

The error message from the parser is somewhat misleading (I’ll see if I can make it more useful), but this has nothing to do with create exact synonym being somehow parsed as createexactsynonym.

The problem is with the for 'ocean floor'. The parser expects a term ID after for, not a string. KGCL-Java does not support using a label where an ID is expected. This is on purpose: you want to modify a term, you are supposed to know its ID; KGCL-Java will not do the lookup for you.

So here, the command should have been

create exact synonym 'ocean basin floor' for ENVO:00000426

@hrshdhgd
Copy link
Author

Thank you for the quick response @gouttegd !

@cmungall
Copy link

Can be closed, but we should continue discussion about labels here: INCATools/kgcl#82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants