Skip to content
This repository has been archived by the owner on Dec 10, 2019. It is now read-only.

Site logo is hard coded in template #4

Open
pandaskii opened this issue Oct 26, 2017 · 5 comments
Open

Site logo is hard coded in template #4

pandaskii opened this issue Oct 26, 2017 · 5 comments
Labels
Milestone

Comments

@pandaskii
Copy link
Contributor

Template:

govcms-ui/templates/includes/_header.html.twig

<img src="/themes/contrib/govcms-ui/govcms-ui/logo.svg" alt="Home" height="70">

@pandaskii pandaskii added the bug label Oct 26, 2017
@imperator99
Copy link
Contributor

Hey @pandaskii what result are you after for this one? I'm happy to work on it but just want to check.

@pandaskii
Copy link
Contributor Author

@imperator99 thanks for the help please go for it.

We had few big changes during the weekend

  • SaSS and UI Kit Bootstrap

https://github.com/govCMS/uikit-bootstrap

https://github.com/govCMS/govCMS8-ui/tree/master/govcms-ui/src/sass

  • To update the UI-Kit Bootstrap run the following...

bash build/update_uikit_bootstrap.sh

@imperator99
Copy link
Contributor

Thanks @pandaskii. Can you let me know what the final result will be? I'm expecting the user to do the following:

  • Select whether to use the default logo (GovCMS) or their own.
  • If they select their own, they can upload a file.
  • The theme automatically includes the file they want without a hardcoded URL.

Does that cover it off?
Cheers,
Jesse.

@pandaskii
Copy link
Contributor Author

screen shot 2017-10-30 at 15 19 46

Yes, I think they are covered

@imperator99
Copy link
Contributor

Okay cool, I'm working on it now (assuming that's a mock-up and not something that already exists).

@pandaskii pandaskii added this to the 1.0.0-alpha2 milestone Jan 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants