Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agreements do not follow I Agree specification #25

Open
motero2k opened this issue Oct 21, 2023 · 0 comments
Open

Agreements do not follow I Agree specification #25

motero2k opened this issue Oct 21, 2023 · 0 comments

Comments

@motero2k
Copy link
Contributor

Currently you can post an agreement without the required parameters by IAgree (Registry do not check this in a POST).

Two options:

  • Make registry ask for all the required parameters:

Problem: The json models schemes do not work the same as the mongo schemes. In mongo we don't know if it is possible to use $ref without problems. If you put required in definitions.yourRefDefinition, mongo understand that definitions is required when it is not.

  • Make I Agree less restrictive: At the time of this issue, this is the currently chosen alternative, at least for now.

Only check required at id,context,terms and type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant