Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Number.isInteger breaks IE and Safari #227

Closed
davidspiess opened this issue Oct 17, 2016 · 5 comments
Closed

Number.isInteger breaks IE and Safari #227

davidspiess opened this issue Oct 17, 2016 · 5 comments

Comments

@davidspiess
Copy link
Contributor

react-day-picker/src/Helpers.js

Line 46 in a5db426

if (Number.isInteger(firstDayOfWeek)) {

@gpbl
Copy link
Owner

gpbl commented Oct 17, 2016

😱 I guess is the missing ES6 polyfill. Switching back to old good JavaScript. Thanks for the report !

@davidspiess
Copy link
Contributor Author

davidspiess commented Oct 17, 2016 •
edited
Loading

Or maybe use typescript? :)

@gpbl
Copy link
Owner

gpbl commented Oct 17, 2016

@davidspiess don't even try... 😁

@gpbl gpbl mentioned this issue Oct 17, 2016
Merged
@gpbl
Copy link
Owner

gpbl commented Oct 17, 2016

This should be fixed in v3.1.1 👍

@gpbl gpbl closed this as completed Oct 17, 2016
@davidspiess
Copy link
Contributor Author

👍🏻 haha thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpbl @davidspiess