Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow after/before modifiers into a same object #354

Closed
3 tasks done
gpbl opened this issue May 20, 2017 · 0 comments
Closed
3 tasks done

Allow after/before modifiers into a same object #354

gpbl opened this issue May 20, 2017 · 0 comments
Milestone
v6.0.0

Comments

@gpbl
Copy link
Owner

gpbl commented May 20, 2017 •
edited
Loading

There's some confusion about using the { before }/{ after } modifiers (e.g. #352 and #324):

// not working
disabledDays={ { before: aDate, after: aDate }}
//  working
disabledDays={ [ { before: aDate}, { after: aDate }] }

The first is indeed more logic...

  • update code to work with { before, after } modifiers
  • update docs
  • update typescript definitions
@gpbl gpbl added this to the v5.6.0 milestone May 20, 2017
@gpbl gpbl mentioned this issue Jun 11, 2017
Merged
@gpbl gpbl closed this as completed in #393 Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v6.0.0
Development

No branches or pull requests
1 participant
@gpbl