Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed render of months when toMonth and numberOfMonth are passed #556

Merged
merged 1 commit into from
Nov 24, 2017

Conversation

hydrognomik
Copy link
Contributor

This PR for #543. In case when toMonth and numberOfMonth are passed to DayPicker and toMonth earlier or equals currentMonth moves currentMonth so toMonth rendered last.

@hydrognomik hydrognomik changed the title Fixed render of months #543 Fixed render of months when toMonth and numberOfMonth are passed Nov 20, 2017
@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #556 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #556   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         558    562    +4     
  Branches      118    120    +2     
=====================================
+ Hits          558    562    +4
Impacted Files Coverage Δ
src/DayPicker.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567e87e...355f861. Read the comment docs.

@gpbl
Copy link
Owner

gpbl commented Nov 23, 2017

Thanks again!! I think we should add a test case for it :)

@hydrognomik do you have the time for this while I'm closing the other issues for the v6.3 release?

@hydrognomik
Copy link
Contributor Author

Yes, sure.

@gpbl gpbl merged commit 33530cb into gpbl:master Nov 24, 2017
@gpbl gpbl added this to the v6.3.0 milestone Nov 24, 2017
@gpbl
Copy link
Owner

gpbl commented Nov 24, 2017

Thanks @hydrognomik for the help! You are great!

@gpbl
Copy link
Owner

gpbl commented Nov 25, 2017

Published in v7!

@leojh
Copy link

leojh commented Dec 19, 2017

Verified!

kimamula pushed a commit to kimamula/react-day-picker that referenced this pull request Aug 17, 2022
Fixed render of months when toMonth and numberOfMonth are passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants