Export more types from index.d.ts

[adidahiya]

Fixes #617

[codecov]

Codecov Report

Merging #618 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #618   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          15     15           
  Lines         621    621           
  Branches      133    133           
=====================================
  Hits          621    621

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3156e3d...1668200. Read the comment docs.

[i8wu]

if you add export * from './DayPickerInput'; it'll also solve #586

[adidahiya]

that is semantically incorrect. DayPickerInput is not exported from the root of the package: https://github.com/gpbl/react-day-picker/blob/master/DayPicker.js

[i8wu]

Hm, what would be the correct way then? Kinda new to typescript.

[adidahiya]

since the JS export is from a submodule, you can import in typescript like this:

import { DayPickerInput } from "react-day-picker/DayPickerInput";

that's why types/DayPickerInput.d.ts exists.

[i8wu]

Importing like that doesn't work, my compiler complains about no declaration file found.

[adidahiya]

hm, ok, can you file an issue for that? I might be able to look into it later

[i8wu]

Should I open up a new issue or is #586 good enough? Thank you!

[alexisthual]

Can someone merge this please? :)

[gpbl]

Hey thanks for the PR! Are we safe with this? I'm not a TS developer, people were fighting for this kind of issues the last time... should I go and merge?

[alexisthual]

I am not a TS expert but this PR seems quite fair to me; you can go ahead and merge I guess :)

[adidahiya]

This is safe; I contributed to the original types on DefinitelyTyped and in this repo. #586 is a separate issue and can be addressed in another PR.

[gpbl]

Thanks @adidahiya as always!

[gpbl]

Published as v7.1.0.

[theigor]

Hi guys - just got latest and getting this error:

ERROR in [at-loader] ./node_modules/react-day-picker/types/props.d.ts:177:27
    TS7006: Parameter 'DayModifiers' implicitly has an 'any' type.

where line 177 is

  onDayChange?(day: Date, DayModifiers): void;

so this seems like a legitimate issue. Did you mean to do

  onDayChange?(day: Date, modifiers:DayModifiers): void;

[theigor]

By the way, you can avoid things like this in the future by switching your tsconfig to

{
  "compilerOptions": {
    "noImplicitAny": true,
    ...
  },
  ...
}