You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First, this plugin is great and it has been a pleasant surprise to discover and use. Kudos and thanks!
Second, I have a question. My GitHub workflow logs in to an AWS container registry, which provides the URL to the registry as an output that looks like 111111111.dkr.ecr.us-west-2.amazonaws.com. For any docker enabled application, to get the full image name, I combine the registry URL with the application name. So, for an application called cloud, the full image name is 111111111.dkr.ecr.us-west-2.amazonaws.com/cloud.
Now, I'm trying to combine the above with a call to nx affected, like so:
npx nx affected -t lint test container
The problem is, neither the registry URL nor the set of applications affected are known until build time. For each affected application, I need to combine the application name with the registry URL provided by a previous build step. Intuitively, I'd want to accomplish this by doing something like this in the cloud application's project.json (note the images value in particular):
Combined with setting the build-time environment variable $REGISTRY_NAME before running nx affected:
REGISTRY_NAME=$ECR_REGISTRY npx nx affected -t lint test build container
Is this possible with nx-container and nx affected builds today? I couldn't find any information regarding a REGISTRY setting independent of the image name, and I'd rather not capture, parse, tag and push the individual projects that were built by the nx affected command.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hello,
First, this plugin is great and it has been a pleasant surprise to discover and use. Kudos and thanks!
Second, I have a question. My GitHub workflow logs in to an AWS container registry, which provides the URL to the registry as an output that looks like
111111111.dkr.ecr.us-west-2.amazonaws.com
. For any docker enabled application, to get the full image name, I combine the registry URL with the application name. So, for an application calledcloud
, the full image name is111111111.dkr.ecr.us-west-2.amazonaws.com/cloud
.Now, I'm trying to combine the above with a call to
nx affected
, like so:npx nx affected -t lint test container
The problem is, neither the registry URL nor the set of applications affected are known until build time. For each affected application, I need to combine the application name with the registry URL provided by a previous build step. Intuitively, I'd want to accomplish this by doing something like this in the cloud application's
project.json
(note theimages
value in particular):Combined with setting the build-time environment variable
$REGISTRY_NAME
before runningnx affected
:REGISTRY_NAME=$ECR_REGISTRY npx nx affected -t lint test build container
Is this possible with
nx-container
andnx affected
builds today? I couldn't find any information regarding a REGISTRY setting independent of the image name, and I'd rather not capture, parse, tag and push the individual projects that were built by thenx affected
command.Additional comment here: #619 (comment)
Cheers and thanks.
Beta Was this translation helpful? Give feedback.
All reactions