Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message presented to the user gives no useful information when adding a tool with invalid url. #423

Closed
sangee2004 opened this issue Sep 4, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@sangee2004
Copy link

Electron build - 81ca1d7

Steps to reproduce the problem:

  1. Chat with Tildy
  2. Use "Add Tool from URL" option and add invalid url like github.com/trash.

User is presented with the following error message:

Screenshot 2024-09-04 at 10 29 42 AM

Expected Behavior:
Error message presented to the user should be more meaningful.

@sangee2004 sangee2004 added the bug Something isn't working label Sep 4, 2024
@sangee2004
Copy link
Author

There is also another case where I see the same error message being presented to the user when uploading of knowledge file failed because of a DNS issue

Screenshot 2024-09-04 at 12 55 17 PM

Errors seen in console:

2024-09-04T19:48:05.825Z [server] [ERROR] Error: Command failed: /Users/sangeethahariharan/acorn/desktop/bin/knowledge ingest --prune --dataset nde6ei /Users/sangeethahariharan/Library/Application\ Support/acorn/Acorn/threads/nde6ei/knowledge
2024/09/04 12:47:45 INFO Created dataset id=nde6ei
2024/09/04 12:47:45 INFO Pruned files count=0 basePath="/Users/sangeethahariharan/Library/Application Support/acorn/Acorn/threads/nde6ei/knowledge"
2024/09/04 12:48:05 ERROR Failed to add documents error="couldn't add document '908f16fc-b8f4-4e43-936e-09cd5354ab6d': couldn't create embedding of document: couldn't send request: Post \"https://gateway-api.gptscript.ai/llm/embeddings\": dial tcp: lookup gateway-api.gptscript.ai on 192.168.1.254:53: read udp 192.168.1.76:56756->192.168.1.254:53: i/o timeout"
2024/09/04 12:48:05 failed to add documents: couldn't add document '908f16fc-b8f4-4e43-936e-09cd5354ab6d': couldn't create embedding of document: couldn't send request: Post "https://gateway-api.gptscript.ai/llm/embeddings": dial tcp: lookup gateway-api.gptscript.ai on 192.168.1.254:53: read udp 192.168.1.76:56756->192.168.1.254:53: i/o timeout

    at genericNodeError (node:internal/errors:984:15)
    at wrappedFn (node:internal/errors:538:14)
    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:519:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket.<anonymous> (node:internal/child_process:457:11)
    at Socket.emit (node:events:519:28)
    at Pipe.<anonymous> (node:net:338:12)
    at Pipe.callbackTrampoline (node:internal/async_hooks:130:17) {
  code: 1,
  killed: false,
  signal: null,
  cmd: '/Users/sangeethahariharan/acorn/desktop/bin/knowledge ingest --prune --dataset nde6ei /Users/sangeethahariharan/Library/Application\\ Support/acorn/Acorn/threads/nde6ei/knowledge',
  stdout: '',
  stderr: '2024/09/04 12:47:45 INFO Created dataset id=nde6ei\n' +
    '2024/09/04 12:47:45 INFO Pruned files count=0 basePath="/Users/sangeethahariharan/Library/Application Support/acorn/Acorn/threads/nde6ei/knowledge"\n' +
    `2024/09/04 12:48:05 ERROR Failed to add documents error="couldn't add document '908f16fc-b8f4-4e43-936e-09cd5354ab6d': couldn't create embedding of document: couldn't send request: Post \\"https://gateway-api.gptscript.ai/llm/embeddings\\": dial tcp: lookup gateway-api.gptscript.ai on 192.168.1.254:53: read udp 192.168.1.76:56756->192.168.1.254:53: i/o timeout"\n` +
    `2024/09/04 12:48:05 failed to add documents: couldn't add document '908f16fc-b8f4-4e43-936e-09cd5354ab6d': couldn't create embedding of document: couldn't send request: Post "https://gateway-api.gptscript.ai/llm/embeddings": dial tcp: lookup gateway-api.gptscript.ai on 192.168.1.254:53: read udp 192.168.1.76:56756->192.168.1.254:53: i/o timeout\n`,
  digest: '1602320271'
}

@ryanhopperlowe
Copy link
Contributor

ryanhopperlowe commented Sep 12, 2024

@sangee2004 - Do you have steps to reproduce for the second issue? I've tried uploading files, and I'm not able to get that DNS Error

@sangee2004
Copy link
Author

@ryanhopperlowe The issue with knowledge file upload happens randomly. I dont have reproducible steps to get to this state.

@cjellick
Copy link
Contributor

There is also another case where I see the same error message being presented to the user when uploading of knowledge file failed because of a DNS issue

completely separate bug from "Error message presented to the user gives no useful information when adding a tool with invalid url."

you can open a separate issue from the second one. the original issue should be addressed.

@sangee2004
Copy link
Author

Logged #508 for tracking issue seen with error message not being shown to user when knowledge file addition fails.

@sangee2004
Copy link
Author

Tested with electron build - 0f259cd7e

Proper error message is presented to the user.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants