Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Texture format capability info does not take device into account #3848

Open
kainino0x opened this issue Jul 8, 2024 · 3 comments
Open

Texture format capability info does not take device into account #3848

kainino0x opened this issue Jul 8, 2024 · 3 comments
Assignees

Comments

@kainino0x
Copy link
Collaborator

Right now we have tables of texture format info that include both static info (like block sizes) and device-dependent info (like whether bgra8unorm can be used as storage - #3847). In the static tables, the capability info is that for a "base" device (no device descriptor).

I am not exactly sure how to do this - it requires passing a device in order to get data out of the table, but right now we're depending heavily on typescript to do nice type narrowing things when we access the table.

I was going to do this as a followup to #2495 but it seems I never filed it separately.

@kainino0x kainino0x self-assigned this Jul 8, 2024
@kainino0x
Copy link
Collaborator Author

Tentatively assigning myself, but not starting on it.

@greggman
Copy link
Contributor

greggman commented Jul 8, 2024

Note that just device is often not sufficient given that compat/non-compat is only passed in on the adapter

So far, if the query needs to know compat/core then I've had a required bool argument that you must pass in to try to make it clear it's compat/core dependent.

@kainino0x
Copy link
Collaborator Author

We should probably try to fix that in the compat proposal - GPUDevice has features and limits so it should also have a way of determining it's compat - either a boolean, or the lack of a 'everything-from-compat-to-core' feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants