You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the test is correct here, since this is an abstract case there is not limit on how many bits can be right shifted, https://www.w3.org/TR/WGSL/#bit-expr. (concrete and abstract right-shift have different defintions).
Thanks for clarifying @zoddicus that makes sense. I suppose the only issue is failing compilation results in the test not recovering, so perhaps minor suggestion to handle the promise rejection. I am also happy to make a PR for this if you have no objections?
The following test:
https://gpuweb.github.io/cts/standalone/?q=webgpu:shader,execution,expression,binary,bitwise_shift:shift_right_abstract:*
fails on Chrome Version 126.0.6478.127 (Official Build) (arm64)
One such failure:
On Safari Technology Preview 198, the test doesn't complete because
submitBatch
doesn't handle a promise rejection:cts/src/webgpu/shader/execution/expression/expression.ts
Line 414 in e7e43bd
Safari rejects the promise because shader compilation fails. The shader compilation fails apparently due to
because the test attempts to perform a right shift operation greater than the number of bits in a 64 bit integer, which we reject.
The text was updated successfully, but these errors were encountered: