You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be great and make our code far less verbose if scenario_best_of would compute the different scenarios alongside comparing them. I'm thinking we could pass in three different lists as arguments:
a list of the scenario functions we want to call,
a list with the corresponding data frames to use for each function (this could potentially just be moved into the list of arguments),
a list with the arguments to pass to each scenario function (this would thus be a list of lists)
That sounds like a good improvement indeed to make the code more readable.
The list of data frames might indeed be superfluous as df is an argument to all scenario functions.
This would make the function much more complicated to use for external users though, as passing lists to functions is a bit out of the most common pipeline for tidyverse users. So it would be great to maintain the current usage, if possible.
It would be great and make our code far less verbose if
scenario_best_of
would compute the different scenarios alongside comparing them. I'm thinking we could pass in three different lists as arguments:And it would then compute everything.
@ElliottMess Thoughts?
The text was updated successfully, but these errors were encountered: