Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): async hooks #90

Merged
merged 1 commit into from
Apr 5, 2021
Merged

fix(types): async hooks #90

merged 1 commit into from
Apr 5, 2021

Conversation

MunifTanjim
Copy link
Contributor

I had no idea that, async hooks like this is supported:

const hook = new Singular()

hook.before(async (options) => {
})

This PR fixes types for that use-case.

@gr2m gr2m changed the title fix(types): async hooks are supported fix(types): async hooks Apr 4, 2021
gr2m
gr2m approved these changes Apr 4, 2021
View reviewed changes
Copy link
Owner

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍🏼

@gr2m gr2m merged commit 45d1921 into gr2m:master Apr 5, 2021
@gr2m
Copy link
Owner

gr2m commented Apr 5, 2021

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m added the released label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MunifTanjim @gr2m