Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Backport: Synchronize accesses to reachability handlers #618

Closed
1 of 2 tasks
zakkak opened this issue Nov 14, 2023 · 3 comments · Fixed by #633
Closed
1 of 2 tasks

[23.0] Backport: Synchronize accesses to reachability handlers #618

zakkak opened this issue Nov 14, 2023 · 3 comments · Fixed by #633
Labels
affects/23.0 backport not-Stale
Milestone
23.0.3.0-Final

Comments

@zakkak
Copy link
Collaborator

zakkak commented Nov 14, 2023

What would you like to backport?

oracle#7736

Why?

Prevents data races in reachability handlers registration when using
-H:-RunReachabilityHandlersConcurrently. Although this option is not the default nor commonly used, we have seen it being used to resolve other issues (e.g. apache/camel-quarkus#5006 (comment)).

Are the changes being backported merged in upstream Graal?

  • Yes
  • No
@zakkak zakkak added this to the 23.0.2.2-Final milestone Nov 14, 2023
@zakkak zakkak mentioned this issue Dec 12, 2023
Merged
@zakkak zakkak linked a pull request Dec 12, 2023 that will close this issue
[23.0] Sync with upstream #633
Merged
@github-actions GitHub Actions
Copy link

This issue appears to be stale because it has been open 30 days with no activity. This issue will be closed in 7 days unless Stale label is removed, a new comment is made, or not-Stale label is added.

@github-actions github-actions bot added the Stale label Dec 15, 2023
@jerboaa jerboaa added not-Stale and removed Stale labels Dec 15, 2023
@jerboaa
Copy link
Collaborator

jerboaa commented Dec 15, 2023

@zakkak wasn't this closed with #633?

@jerboaa jerboaa modified the milestones: 23.0.2.2-Final, 23.0.3.0-Final Dec 15, 2023
@zakkak
Copy link
Collaborator Author

zakkak commented Dec 15, 2023

Well it should, but it looks like github failed to do so :)

@zakkak zakkak closed this as completed Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/23.0 backport not-Stale
Projects
None yet
Milestone
23.0.3.0-Final
Development

Successfully merging a pull request may close this issue.

[23.0] Sync with upstream zakkak/mandrel
2 participants
@jerboaa @zakkak