Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass mock context when resetting the DB #207

Merged
merged 2 commits into from
Nov 23, 2023
Merged

fix: pass mock context when resetting the DB #207

merged 2 commits into from
Nov 23, 2023

Conversation

spaenleh
Copy link
Member

No description provided.

@spaenleh spaenleh requested a review from ReidyT November 22, 2023 14:06
@spaenleh spaenleh self-assigned this Nov 22, 2023
@spaenleh spaenleh added the bug 🪲 Something isn't working label Nov 22, 2023
ReidyT
ReidyT approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the duplication of LocalContext in buildMSWMocks is wanted, then this PR seems to be ok. Otherwise, I would suggest to ask apiHost explicitly in the buildMSWMocks function.

src/mockServer/msw/handlers.ts Outdated Show resolved Hide resolved
src/mockServer/msw/server.ts Outdated Show resolved Hide resolved
@spaenleh
Copy link
Member Author

@ReidyT I had missed the duplication. Fixed in the new commits. Thank you for noticing 👍

@spaenleh spaenleh merged commit 07847b8 into main Nov 23, 2023
2 checks passed
@spaenleh spaenleh deleted the fix-reset-mock-context branch November 23, 2023 15:43
@github-actions github-actions bot mentioned this pull request Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working v3.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spaenleh @ReidyT