Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name to query param for setting #223

Merged
merged 12 commits into from
Dec 19, 2023
Merged

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Dec 14, 2023

fix #222
fix #224

@spaenleh spaenleh added the feature New feature or request label Dec 18, 2023
@spaenleh spaenleh requested a review from pyphilia December 18, 2023 10:32
@spaenleh spaenleh self-assigned this Dec 18, 2023
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🇨🇽

Comment on lines 8 to 9
single: () => [...appSettingKeys.all, 'single'] as const,
singleId: (id?: UUID, filters?: { [key: string]: unknown }) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
single: () => [...appSettingKeys.all, 'single'] as const,
singleId: (id?: UUID, filters?: { [key: string]: unknown }) =>
allSingles: () => [...appSettingKeys.all, 'single'] as const,
single: (id?: UUID, filters?: { [key: string]: unknown }) =>

@spaenleh spaenleh merged commit 483e37c into main Dec 19, 2023
2 checks passed
@spaenleh spaenleh deleted the 222-query-setting-by-name branch December 19, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v3.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] apps do not resize [app-setting] Allow to query app settings by name
2 participants