-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
48 refactor ci pipeline #49
Conversation
Added |
Updated the build job for ecs-backend. Now the ecs-backend workflow has the following jobs:
|
Updated the build job for ecs-explorer. Now the ecs-explorer workflow has the following jobs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Just some minor changes. Also, check to see if you can factor out the TASK DEFINITION
and the NUMBER OF TASKS
in a JSON for the ECS workflow.
@victorggonzalez @pyphilia, is this ready to merge? |
I think this PR is too far behind the main branch to be applied. We should report the changes to a new branch. I've already applied cache to workflows with a composite so this part is already done. |
This PR contains:
cdelivery-*.yml
workflows. We now perform the integration test job in the Graasp Deploy workflowcintegration-ecs-explorer.yml
: include test job that matches the currentcypress.yml
workflow inside the library repo.cintegration-s3-apps.yml
: include test job that matches the currentcypress.yml
workflow inside apps repos. Add cache to build and deploy jobs to improve speed.cintegration-s3.yml
: include test job that matches the currentcypress.yml
workflow inside s3 repos. Add cache to build and deploy jobs to improve speed.*-caller.yml
workflows to improve the changes made