Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

feat: show next-prev buttons #441

Merged
merged 8 commits into from
Mar 12, 2024
Merged

feat: show next-prev buttons #441

merged 8 commits into from
Mar 12, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Dec 22, 2023 •
edited
Loading

To continue on this PR, we need relative links!

pyphilia
pyphilia commented Mar 5, 2024
View reviewed changes
Copy link
Contributor Author

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice folders automatically get folded when we click on another folder in the left navigation. Is it intended? I was surprised but I think it make sense, we can discuss.

Let's update the backend so you can get the correct order.

src/modules/item/NavigationButton.tsx Outdated Show resolved Hide resolved
src/modules/item/NavigationButton.tsx Show resolved Hide resolved
src/modules/navigation/tree/TreeView.tsx Outdated Show resolved Hide resolved
src/modules/navigation/tree/TreeView.tsx Outdated Show resolved Hide resolved
src/modules/item/NavigationButton.tsx Show resolved Hide resolved
src/modules/item/NavigationButton.tsx Outdated Show resolved Hide resolved
src/modules/item/NavigationButton.tsx Outdated Show resolved Hide resolved
@juancarlosfarah
Copy link
Member

I notice folders automatically get folded when we click on another folder in the left navigation. Is it intended? I was surprised but I think it make sense, we can discuss.

Let's update the backend so you can get the correct order.

@pyphilia, yes. I think this is good navigation when using the buttons.

@juancarlosfarah
Copy link
Member

@pyphilia, I've applied the suggested changes and made a few changes. Otherwise, I left a comment a few questions. Please let me know how to proceed. Thanks!

@juancarlosfarah
Copy link
Member

@pyphilia @spaenleh, I've made the changes. Please let me know if it's OK!

@spaenleh spaenleh marked this pull request as ready for review March 12, 2024 13:50
spaenleh
spaenleh approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ! Thank you for the changes 👍

@spaenleh spaenleh force-pushed the player-navigation branch from 10392bb to 7a05a44 Compare March 12, 2024 13:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 0647864 Mar 12, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 12, 2024
Merged
@spaenleh spaenleh deleted the player-navigation branch March 12, 2024 14:31
@pyphilia pyphilia mentioned this pull request Mar 12, 2024
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juancarlosfarah juancarlosfarah juancarlosfarah left review comments

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

@spaenleh spaenleh

Labels
v2.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pyphilia @juancarlosfarah @spaenleh