Skip to content
This repository has been archived by the owner on Nov 28, 2024. It is now read-only.

fix: handle undefined childrenOrder #483

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: handle undefined childrenOrder #483

merged 2 commits into from
Jan 22, 2024

Conversation

pyphilia
Copy link
Contributor

childrenOrder might not exist (but it's not highlighted by the type because it suppose it always exist). Probably we should run a migration?

@pyphilia pyphilia requested review from spaenleh and ReidyT January 22, 2024 09:55
@pyphilia pyphilia self-assigned this Jan 22, 2024
@pyphilia pyphilia added the bug 🪲 Something isn't working label Jan 22, 2024
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spaenleh
Copy link
Member

@pyphilia Yes probably the best thing to do would be to create the order from the updatedAt column in the children. So there is always one.

@pyphilia pyphilia merged commit b2470fc into main Jan 22, 2024
4 checks passed
@pyphilia pyphilia deleted the fix-tree branch January 22, 2024 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug 🪲 Something isn't working v2.4.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants