Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update main component and refactor #491

Merged
merged 7 commits into from
Feb 2, 2024
Merged

fix: update main component and refactor #491

merged 7 commits into from
Feb 2, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Feb 1, 2024 •
edited
Loading

Update main component and add a pagination to the home page.

@spaenleh spaenleh self-assigned this Feb 1, 2024
ReidyT
ReidyT approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I just let some comments 😄

src/App.tsx Show resolved Hide resolved
src/config/selectors.ts Outdated Show resolved Hide resolved
src/modules/pages/HomePage.tsx Show resolved Hide resolved
pyphilia
pyphilia approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚥

src/modules/item/ItemForbiddenScreen.tsx Outdated Show resolved Hide resolved
@spaenleh spaenleh mentioned this pull request Feb 2, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 2, 2024 •
edited
Loading

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.3% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh merged commit cbe0ad9 into main Feb 2, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Jan 31, 2024
Merged
@spaenleh spaenleh deleted the update-main-component branch February 2, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyphilia pyphilia pyphilia approved these changes

@ReidyT ReidyT ReidyT approved these changes

@LinaYahya LinaYahya Awaiting requested review from LinaYahya

Assignees

@spaenleh spaenleh

Labels
improvement v2.4.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spaenleh @pyphilia @ReidyT