Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create navigation island #576

Merged
merged 10 commits into from
Mar 25, 2024
Merged

feat: create navigation island #576

merged 10 commits into from
Mar 25, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Mar 20, 2024

In this PR:

  • fix Implement navigation island #570 implement the first proposal for the navigation island
  • use 2 level navigation, which allows to specifx the root and the current item in the url
  • add a redirection from /:rootId to /:rootId/:rootId to not break compatibility

This should fix multiple issues:

Updated look of the island:
Screenshot 2024-03-21 at 16 06 57

With pinned item and chatbox closed:
Screenshot 2024-03-21 at 16 06 49

With pinned open and chatbox closed
Screenshot 2024-03-21 at 16 06 43

Only chat closed:
Screenshot 2024-03-21 at 16 06 34

Interaction video:
https://github.com/graasp/graasp-player/assets/39373170/c471acd8-3c21-4302-a9bf-465513c1804f

@spaenleh spaenleh added the feature New feature or request label Mar 20, 2024
@spaenleh spaenleh requested a review from pyphilia March 20, 2024 18:44
@spaenleh spaenleh self-assigned this Mar 20, 2024
Copy link
Contributor

@pyphilia pyphilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR ! 🐞 LGTM, I guess your working on the chatbox button for non-folder as we discussed.

.github/workflows/cypress.yml Show resolved Hide resolved
src/App.tsx Outdated Show resolved Hide resolved
src/modules/item/NavigationIsland.tsx Outdated Show resolved Hide resolved
src/modules/item/NavigationIsland.tsx Outdated Show resolved Hide resolved
src/modules/item/NavigationIsland.tsx Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Mar 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.6% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 76d5e21 Mar 25, 2024
4 checks passed
@spaenleh spaenleh deleted the 570-navigation-island branch April 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request v2.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement navigation island Page does not scroll to top on navigate to section
2 participants