Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix tree crash bug #603

Merged
merged 1 commit into from
Apr 4, 2024
Merged

fix: Fix tree crash bug #603

merged 1 commit into from
Apr 4, 2024

Conversation

pyphilia
Copy link
Contributor

@pyphilia pyphilia commented Apr 4, 2024

No description provided.

@pyphilia pyphilia requested a review from spaenleh April 4, 2024 11:53
@pyphilia pyphilia self-assigned this Apr 4, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

spaenleh
spaenleh approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@spaenleh spaenleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the (easy) change, I was too afraid to do this, but as discussed this is the best solution since the react-accessible-tree keeps an internal state. So we have to destroy the component and re-create it when the root changes.

🚀

@spaenleh spaenleh added the bug 🪲 Something isn't working label Apr 4, 2024
@pyphilia pyphilia enabled auto-merge April 4, 2024 12:02
@pyphilia pyphilia added this pull request to the merge queue Apr 4, 2024
Merged via the queue into main with commit 863939a Apr 4, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 3, 2024
Merged
@spaenleh spaenleh deleted the fix-tree-crash-bug branch April 17, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spaenleh spaenleh spaenleh approved these changes

Assignees

@pyphilia pyphilia

Labels
bug 🪲 Something isn't working v2.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pyphilia @spaenleh