Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pins should not be inherited #849

Merged
merged 3 commits into from
Sep 13, 2024
Merged

fix: pins should not be inherited #849

merged 3 commits into from
Sep 13, 2024

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Sep 13, 2024 •
edited
Loading

fix #841

@spaenleh spaenleh self-assigned this Sep 13, 2024
@spaenleh spaenleh added the bug 🪲 Something isn't working label Sep 13, 2024
@spaenleh spaenleh changed the title fix: add a regression test that should fail fix: pins should not be inherited Sep 13, 2024
ReidyT
ReidyT approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@ReidyT ReidyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, LGTM

src/modules/navigation/tree/LoadingTree.tsx Outdated Show resolved Hide resolved
src/modules/rightPanel/SideContent.tsx Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarCloud

@spaenleh spaenleh added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 6b1cbec Sep 13, 2024
4 checks passed
@graasper graasper mentioned this pull request Sep 13, 2024
Merged
@spaenleh spaenleh deleted the 841-pins-should-not-inherit branch September 13, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReidyT ReidyT ReidyT approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
bug 🪲 Something isn't working v2.18.1
Projects
None yet
Milestone
No milestone
2 participants
@spaenleh @ReidyT