Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing notifications translations #146

Merged
merged 2 commits into from
Apr 13, 2023
Merged

fix: add missing notifications translations #146

merged 2 commits into from
Apr 13, 2023

Conversation

spaenleh
Copy link
Member

@spaenleh spaenleh commented Apr 12, 2023 •
edited
Loading

This PR adds missing notifications translations.

@spaenleh spaenleh linked an issue Apr 12, 2023 that may be closed by this pull request
Add notification translations #145
Closed
@spaenleh spaenleh requested a review from codeofmochi April 12, 2023 14:11
@spaenleh spaenleh self-assigned this Apr 12, 2023
@spaenleh spaenleh added chore Generic task or chore improvement labels Apr 12, 2023
@spaenleh spaenleh requested a review from pyphilia April 12, 2023 15:53
codeofmochi
codeofmochi requested changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicks on linguistics

src/langs/en/chatbox.json Outdated Show resolved Hide resolved
src/langs/fr/chatbox.json Outdated Show resolved Hide resolved
@spaenleh
fix(wording): apply suggestions from code review
3462d1a 
Co-authored-by: Alexandre Chau <dialexo@users.noreply.github.com>
@spaenleh spaenleh requested a review from codeofmochi April 13, 2023 06:17
@spaenleh spaenleh merged commit 88f1f29 into main Apr 13, 2023
@spaenleh spaenleh deleted the 145-add-notification-translations branch April 13, 2023 08:21
@github-actions github-actions bot mentioned this pull request Apr 13, 2023
Merged
@github-actions github-actions bot mentioned this pull request Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeofmochi codeofmochi codeofmochi approved these changes

@pyphilia pyphilia Awaiting requested review from pyphilia

Assignees

@spaenleh spaenleh

Labels
chore Generic task or chore improvement v1.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add notification translations
2 participants
@spaenleh @codeofmochi