Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rename recycle into trash and add missing translations #86

Merged
merged 3 commits into from
Dec 14, 2022
Merged

Conversation

spaenleh
Copy link
Member

This PR updates some recycling related translations and adds missing translations in french.

closes #85

@spaenleh spaenleh added the bug Something isn't working label Dec 14, 2022
@spaenleh spaenleh self-assigned this Dec 14, 2022
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if using the plural or singular form of "aucun" makes more sense... I've left a link to the Larousse page, i'll let you decide 🎲

src/langs/fr/messages.json Outdated Show resolved Hide resolved
src/langs/fr/messages.json Outdated Show resolved Hide resolved
spaenleh and others added 2 commits December 14, 2022 17:36
Co-authored-by: Alexandre Chau <dialexo@users.noreply.github.com>
Co-authored-by: Alexandre Chau <dialexo@users.noreply.github.com>
@spaenleh
Copy link
Member Author

Thank you for these suggestions @dialexo I choose the plural forms as they made more sens to me !

@spaenleh spaenleh requested a review from codeofmochi December 14, 2022 16:37
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes 🇫🇷

@spaenleh spaenleh merged commit 7056837 into main Dec 14, 2022
@spaenleh spaenleh deleted the 85-trash branch December 14, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change Recycle to Trash in english
2 participants