Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to choose where the debug toggle sits #12

Open
brendanheywood opened this issue Jun 3, 2024 · 4 comments
Open

Add options to choose where the debug toggle sits #12

brendanheywood opened this issue Jun 3, 2024 · 4 comments

Comments

@brendanheywood
Copy link

There has been some discussion around where the toggle should sit. Some options:

  1. in the top nav bar (where it is now)
  2. in the menu under the profile drop down - still on every page and quick to access but less cluttered up front
  3. somewhere else more buried? I'm less keen on this as if it isn't handy then it won't be as convenient to use
@dmitriim
Copy link

dmitriim commented Jun 3, 2024

+ 1 for this one.

IMHO you don't want this toggle to be around all the time.
How important is to know that it's on/off so you want a toggle be always visible?
How often do you need to change adhoc debugging?

@dmitriim
Copy link

dmitriim commented Jun 3, 2024

Ah I think I read it incorrectly. I was confused and thought the toggle enables adhoc task debugging 🤦‍♂️

@jwalits
Copy link

jwalits commented Jul 11, 2024

We just had a request from a client to have the icon not visible on the navbar at all.

Maybe we have a option in the settings, to choose where this option sits. Have two options - visible all the time like it is now or in the usermenu?

@brendanheywood
Copy link
Author

The other benefit of moving it to the user menu over render_navbar_output is that render_navbar_output just accepts random html, it would be better if we used a callback or hook which accepted an action_link so that no matter where it was injected if would look correct in the current theme.

This would need to land first in core:

https://tracker.moodle.org/browse/MDL-71823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants